From: Josef Weidendorfer Date: Sat, 21 Oct 2006 15:40:25 GMT Subject: Re: [PATCH 2/2] Remove dead code after direct graph drawing Message-ID: <200610211740.26128.Josef.Weidendorfer@gmx.de> In-Reply-To: On Saturday 21 October 2006 08:35, you wrote: > Josef, > > I think ther's a leak somewhere. I am not really sure... I just scrolled up and down through the kernel repo with the page up/down keys (around 34K revisions). On the first pass down, the memory increases by around 26 MB, which could by correct, as you do setupData() lazy (no idea what this function does...). On the 2nd pass up again, I only get an increase of around 2 MB. That could be other effects, as on further passes, I do not see any change with pure scrolling. > Checking memory use with ksysguard is see memory use going up > scrolling up and down also on the same revisions list view subset. > > I'm not sure it depends on your patch though. Can you compare with/without my patch? I have no idea what could have introduced any leak here. I do not create any new class instance / structures, but only get rid of pixmap creations/deletions. How did you check for leaks in the past? Did you try valgrind (memcheck or massif)? Josef > > Marco > >