git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/5] gitweb: Quote filename in HTTP Content-Disposition: header

From
Jakub Narebski <jnareb@gmail.com>
Date
Sep 26, 2006, 07:51 UTC
Message-ID
<200609260951.31806.jnareb@gmail.com>
In-Reply-To
<7v7izrw9la.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
Show 9 quoted lines
> Jakub Narebski <jnareb@gmail.com> writes:
> 
>> Finish work started by a2f3db2f5de2a3667b0e038aa65e3e097e642e7d commit
>> (although not documented in commit message) of quoting using quotemeta
>> the filename in HTTP -content_disposition header.  Uniquify output.
>>
>> Just in case filename contains end of line character.
> 
> What do you mean by "uniquify output"?

It means alsways use 'inline; filename="' . (quotemeta <whatever>) . '"', and not sometimes qq(...), sometimes "...\"...\"", and sometimes '...'.

-- 
Jakub Narebski
Poland
Previous: Junio C Hamano
Message 10 of 10 in “gitweb: A few code cleanup patches”
  1. 0/5 gitweb: A few code cleanup patchesJakub Narebski, Sep 25, 2006
  2. 1/5 gitweb: Strip trailing slashes from $path in git_get_hash_by_pathJakub Narebski, Sep 25, 2006
  3. 2/5 gitweb: Use "return" instead of "return undef" for some subsJakub Narebski, Sep 25, 2006
  4. 3/5 gitweb: Split validate_input into validate_pathname and validate_refnameJakub Narebski, Sep 25, 2006
  5. Junio C HamanoSep 26, 2006
  6. Jakub NarebskiSep 26, 2006
  7. 4/5 gitweb: Add git_url subroutine, and use it to quote full URLsJakub Narebski, Sep 25, 2006
  8. 5/5 gitweb: Quote filename in HTTP Content-Disposition: headerJakub Narebski, Sep 25, 2006
  9. Junio C HamanoSep 26, 2006
  10. Jakub NarebskiSep 26, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.