From: Jakub Narebski <jnareb@gmail.com>
Date: Tue, 26 Sep 2006 07:51:31 GMT
Subject: Re: [PATCH 5/5] gitweb: Quote filename in HTTP Content-Disposition: header
Message-ID: <200609260951.31806.jnareb@gmail.com>
In-Reply-To: <7v7izrw9la.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
> 
>> Finish work started by a2f3db2f5de2a3667b0e038aa65e3e097e642e7d commit
>> (although not documented in commit message) of quoting using quotemeta
>> the filename in HTTP -content_disposition header.  Uniquify output.
>>
>> Just in case filename contains end of line character.
> 
> What do you mean by "uniquify output"?

It means alsways use 'inline; filename="' . (quotemeta <whatever>) . '"',
and not sometimes qq(...), sometimes "...\"...\"", and sometimes '...'.

-- 
Jakub Narebski
Poland