git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/5] gitweb: Strip trailing slashes from $path in git_get_hash_by_path

From
Jakub Narebski <jnareb@gmail.com>
Date
Sep 25, 2006, 23:54 UTC
Message-ID
<200609260154.24488.jnareb@gmail.com>
In-Reply-To
<200609260153.08503.jnareb@gmail.com>
It also removes unused local variable $tree 
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 66be619..2ad7eed 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -710,7 +710,7 @@ sub git_get_hash_by_path {
 	my $path = shift || return undef;
 	my $type = shift;
 
-	my $tree = $base;
+	$path =~ s,/+$,,;
 
 	open my $fd, "-|", git_cmd(), "ls-tree", $base, "--", $path
 		or die_error(undef, "Open git-ls-tree failed");
-- 
1.4.2.1
Previous: Jakub NarebskiNext: Jakub Narebski
Message 2 of 10 in “gitweb: A few code cleanup patches”
  1. 0/5 gitweb: A few code cleanup patchesJakub Narebski, Sep 25, 2006
  2. 1/5 gitweb: Strip trailing slashes from $path in git_get_hash_by_pathJakub Narebski, Sep 25, 2006
  3. 2/5 gitweb: Use "return" instead of "return undef" for some subsJakub Narebski, Sep 25, 2006
  4. 3/5 gitweb: Split validate_input into validate_pathname and validate_refnameJakub Narebski, Sep 25, 2006
  5. Junio C HamanoSep 26, 2006
  6. Jakub NarebskiSep 26, 2006
  7. 4/5 gitweb: Add git_url subroutine, and use it to quote full URLsJakub Narebski, Sep 25, 2006
  8. 5/5 gitweb: Quote filename in HTTP Content-Disposition: headerJakub Narebski, Sep 25, 2006
  9. Junio C HamanoSep 26, 2006
  10. Jakub NarebskiSep 26, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.