Re: [PATCH 3/3] git-commit.sh: convert run_status to a C builtin

From: Jeff King <peff@peff.net>
Date: Sep 8, 2006, 07:34 UTC
Message-ID: <20060908073452.GA25343@coredump.intra.peff.net>
In-Reply-To: <7v64fynbpg.fsf@assigned-by-dhcp.cox.net>

On Thu, Sep 07, 2006 at 10:56:11PM -0700, Junio C Hamano wrote:

> I just wanted to point it out because I felt the names to
> programmers are slightly different matter.

Fair enough. Do you want to change git-runstatus? It should ideally not be used by end users at all (and hopefully can eventually go away if git-status and git-commit become builtins).

> > wt_status? ucu_status (updated, changed, untracked)?
> Yeah, something along those lines.

I think wt_status is the most reasonable of those.

> In a distant past I saw some terminals get confused near the
> edge if you do that, but these days everybody is on some sort of
> Xterm so it may not matter.  But that would probably be nice to
> fix.

OK, it will take a little wrangling with the color_printf interface, but it should be doable.

> > OK. Besides the things you mentioned, what improvements would you like
> > to see?
> Besides the things I mentioned?  I dunno offhand -- otherwise I
> would have mentioned them ;-).

Heh. OK, I assumed your previous comment hinted at hidden depths of dissatisfaction, but clearly not. :) Patches forthcoming...

-Peff