Re: [PATCH] Move color option parsing out of diff.c and into color.[ch]
- From
Jeff King <peff@peff.net>
- Date
- Sep 8, 2006, 09:12 UTC
- Message-ID
- <20060908091206.GA5758@coredump.intra.peff.net>
- In-Reply-To
- <7vk64eivzj.fsf@assigned-by-dhcp.cox.net>
On Fri, Sep 08, 2006 at 01:49:20AM -0700, Junio C Hamano wrote:
Show 7 quoted lines
> > + if (trail)
> > + r += printf("%s", trail);
> > + if (*color)
> > + r += printf("%s", COLOR_RESET);
> > + return r;
> > +}
> Hmm,... don't you mean RESET first and then trail (which is often "\n")?ARGH. Yes, sorry about that. I wrote it correctly once, and then refactored it to be wrong. :)
> Please spell NULL not 0 (please do not argue that writing a NULL
Sorry, I should clearly go read the linux CodingStyle doc before subjecting you to any more of my patches.
I'm assuming you can mark both of those up yourself rather than having me resend?
-Peff