Re: [PATCH 0/5] Rework diff options
- From
- Timo Hirvonen <tihirvon@gmail.com>
- Date
- Jun 23, 2006, 22:44 UTC
- Message-ID
- <20060624014420.2c3df276.tihirvon@gmail.com>
- In-Reply-To
- <Pine.LNX.4.63.0606240024460.29667@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 13 quoted lines
> Hi, > > On Sat, 24 Jun 2006, Timo Hirvonen wrote: > > > This patch series cleans up diff output format options. > > Very good. > > Although I understand that to convert all users to the new convention, it > is sensible to rename the constants, I think it is not good to change > something as DIFF_FORMAT_RAW to OUTPUT_FMT_RAW in the resulting patch. > > IMHO it is an unnecessary change, and accounts for a lot of the diffstat.
I did it because you can't have many DIFF_FORMAT_* options at the same time but OUTPUT_FMT_* can be combined.
-- http://onion.dynserv.net/~timo/