From: Timo Hirvonen Date: Fri, 23 Jun 2006 22:44:20 GMT Subject: Re: [PATCH 0/5] Rework diff options Message-ID: <20060624014420.2c3df276.tihirvon@gmail.com> In-Reply-To: Johannes Schindelin wrote: > Hi, > > On Sat, 24 Jun 2006, Timo Hirvonen wrote: > > > This patch series cleans up diff output format options. > > Very good. > > Although I understand that to convert all users to the new convention, it > is sensible to rename the constants, I think it is not good to change > something as DIFF_FORMAT_RAW to OUTPUT_FMT_RAW in the resulting patch. > > IMHO it is an unnecessary change, and accounts for a lot of the diffstat. I did it because you can't have many DIFF_FORMAT_* options at the same time but OUTPUT_FMT_* can be combined. -- http://onion.dynserv.net/~timo/