git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] Rework diff options

From
Junio C Hamano <junkio@cox.net>
Date
Jun 23, 2006, 23:28 UTC
Message-ID
<7vodwj8n9s.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<Pine.LNX.4.63.0606240024460.29667@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 11 quoted lines
> Hi,
>
> On Sat, 24 Jun 2006, Timo Hirvonen wrote:
>
>> This patch series cleans up diff output format options.
>
> Very good.
>
> Although I understand that to convert all users to the new convention, it 
> is sensible to rename the constants, I think it is not good to change 
> something as DIFF_FORMAT_RAW to OUTPUT_FMT_RAW in the resulting patch.

I personally feel that the benefit of being able to make sure you covered everything outweighs the size of initial diff.

Thanks Timo.  Will take a look.
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 5 of 8 in “Rework diff options”
  1. 0/5 Rework diff optionsTimo Hirvonen, Jun 23, 2006
  2. Johannes SchindelinJun 23, 2006
  3. Timo HirvonenJun 23, 2006
  4. Johannes SchindelinJun 23, 2006
  5. Junio C HamanoJun 23, 2006
  6. Johannes SchindelinJun 24, 2006
  7. Junio C HamanoJun 24, 2006
  8. Linus TorvaldsJun 23, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.