Re: [PATCH] fsmonitor: eliminate call to deprecated FSEventStream function

From: Victoria Dye <vdye@github.com>
Date: Dec 2, 2022, 21:17 UTC
Message-ID: <1b090929-f2da-f075-01d4-458804fc0717@github.com>
In-Reply-To: <221202.86359xfs5c.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason wrote:

> Anyway, that larger topic aside. All I'm suggesting here is that the
> proposed patch seems to at least soft-deprecate versions of OSX we
> supported before. Maybe that's fine, but the commit message didn't get
> across whether that was considered, part of the plan etc.

...

> But git gets ported and backported to a long tail of systems way beyond
> that. Eventually we do need to let got, but we've generally drawn the
> line at some fuzzy notion of when users don't care anymore, along with
> whether it's worth the effort to find out.

My point is that such a user for this scenario is so unlikely to exist that holding up this patch - which provides a real, tangible benefit to developers *right now* - to implement your suggestion or modify the commit message is, at best, an unnecessary distraction.

If, somewhere, there is a user that 1) keeps up-to-date with the latest version of Git, 2) uses FSMonitor, and 3) is working on the sole version of MacOS that was theoretically compatible with FSMonitor before this change but now is not, we can accommodate that once such a need is shown to exist.