Re: [PATCH] fsmonitor: eliminate call to deprecated FSEventStream function

From: Victoria Dye <vdye@github.com>
Date: Dec 2, 2022, 19:51 UTC
Message-ID: <4711d955-02b2-f599-7f89-b442dd0b6215@github.com>
In-Reply-To: <221202.867cz9fwnf.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason wrote:

Show 16 quoted lines

> 
> On Fri, Dec 02 2022, Jeff Hostetler wrote:
> 
>> On 12/2/22 1:02 PM, Ævar Arnfjörð Bjarmason wrote:
>> So, based on the ages of those two Apple releases, I'd like to think
>> that we're fine just switching over and not having to ifdef-up the
>> config.mak.uname.  (If it were a more recent change in the OS, then
>> yeah the answer would be different.)
>>
>> Thoughts ???
> 
> That seems reasonable to me, but it came out in 2001, and we'd be moving
> the dependency to a 2007 version.
> 
> Is that OK? No idea, I don't know how old of an OSX version people
> reasonably run & want to compile Git on.

I appreciate the diligence, but I don't think continuing this discussion will be productive use anyone's time.

Apple doesn't seem to provide official end-of-life dates for their OS versions, but we can extrapolate from the list of obsolete hardware [1] that it likely doesn't support OS versions older than 2014; that's corroborated by their official set of release notes going only as far back as 10.14, released in 2018). In other words, I think it's safe to say that a version supplanted in 2009 is old enough to not warrant Git support.

Thanks,
- Victoria

[1] https://support.apple.com/en-us/HT201624 [2] ttps://developer.apple.com/documentation/macos-release-notes

Show 10 quoted lines

> 
> But in 842c9edec64 (fsmonitor: enable fsmonitor for Linux, 2022-11-23)
> which is new in this upcoming release we seem to have set that
> dependency at 10.4.
> 
> Now, you can unset FSMONITOR_DAEMON_BACKEND and FSMONITOR_OS_SETTINGS in
> your config.mak.uname, but that's probably something that should be
> noted more prominently.
> 
> Eric? [CC'd]