git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] osx-keychain: fix compiler warning

From
Derrick Stolee <derrickstolee@github.com>
Date
Jul 19, 2022, 17:30 UTC
Message-ID
<19ab5c2b-6506-18c1-b8c1-b96074442edf@github.com>
In-Reply-To
<pull.1293.git.1658251503775.gitgitgadget@gmail.com>
On 7/19/2022 1:25 PM, Lessley Dennington via GitGitGadget wrote:
Show 5 quoted lines
> From: Lessley Dennington <lessleydennington@gmail.com>
> 
> Update git-credential-osxkeychain.c to remove 'format string is not a string
> literal (potentially insecure)' compiler warning by treating the string as
> an argument.
>  	if (!argv[1])
> -		die(usage);
> +		die("%s", usage);

Thanks for preparing this for upstream. I reviewed this change as we were doing related things in the microsoft/git fork. LGTM here, too.

Thanks, -Stolee

Previous: Lessley Dennington via GitGitGadgetNext: Junio C Hamano
Message 2 of 4 in “osx-keychain: fix compiler warning”
  1. osx-keychain: fix compiler warningLessley Dennington via GitGitGadget, Jul 19, 2022
  2. Derrick StoleeJul 19, 2022
  3. Junio C HamanoJul 19, 2022
  4. Glen ChooJul 19, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.