Re: [PATCH] osx-keychain: fix compiler warning

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 19, 2022, 18:24 UTC
Message-ID: <xmqq8roparkd.fsf@gitster.g>
In-Reply-To: <pull.1293.git.1658251503775.gitgitgadget@gmail.com>

"Lessley Dennington via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 8 quoted lines

> From: Lessley Dennington <lessleydennington@gmail.com>
>
> Update git-credential-osxkeychain.c to remove 'format string is not a string
> literal (potentially insecure)' compiler warning by treating the string as
> an argument.
>
> Signed-off-by: Lessley Dennington <lessleydennington@gmail.com>
> ---

Perfect.  Thanks.  Will queue.

Show 11 quoted lines

> @@ -168,7 +168,7 @@ int main(int argc, const char **argv)
>  		"usage: git credential-osxkeychain <get|store|erase>";
>  
>  	if (!argv[1])
> -		die(usage);
> +		die("%s", usage);
>  
>  	read_credential();
>  
>
> base-commit: 71a8fab31b70c417e8f5b5f716581f89955a7082