From: Derrick Stolee <derrickstolee@github.com>
Date: Tue, 19 Jul 2022 17:30:32 GMT
Subject: Re: [PATCH] osx-keychain: fix compiler warning
Message-ID: <19ab5c2b-6506-18c1-b8c1-b96074442edf@github.com>
In-Reply-To: <pull.1293.git.1658251503775.gitgitgadget@gmail.com>

On 7/19/2022 1:25 PM, Lessley Dennington via GitGitGadget wrote:
> From: Lessley Dennington <lessleydennington@gmail.com>
> 
> Update git-credential-osxkeychain.c to remove 'format string is not a string
> literal (potentially insecure)' compiler warning by treating the string as
> an argument.

>  	if (!argv[1])
> -		die(usage);
> +		die("%s", usage);

Thanks for preparing this for upstream. I reviewed this change as we
were doing related things in the microsoft/git fork. LGTM here, too.

Thanks,
-Stolee