git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/2] trailer: append trailers in-process and drop the fork to `interpret-trailers`

From
Li Chen <me@linux.beauty>
Date
Jun 12, 2025, 05:40 UTC
Message-ID
<19762a71ab1.d16b43db461922.5615394257517989238@linux.beauty>
In-Reply-To
<xmqqa56ejnrk.fsf@gitster.g>
Hi Junio & Phillip,
 ---- On Wed, 11 Jun 2025 23:34:07 +0800  Junio C Hamano <gitster@pobox.com> wrote --- 
 > phillip.wood123@gmail.com writes:
 > 
 > > Exactly - I was expecting to see a refactoring of interpret_trailers()
 > > in builtin/interpret-trailers.c that moved most of the function body
 > > into a new function in trailer.c that added the trailers to an
 > > strbuf. This seems to be a parallel implementation which doesn't sound
 > > like the best plan.
 > >
 > > I'm going to be off the list for a couple of weeks, I'll take a more
 > > detailed look at this series when I'm back
Thanks for your suggestion; I will refactor it in the next version.

Regards, Li

Previous: Junio C HamanoNext: Li Chen
Message 6 of 7 in “rebase: support --trailer”
  1. 0/2 rebase: support --trailerLi Chen, Jun 10, 2025
  2. 1/2 trailer: append trailers in-process and drop the fork to `interpret-trailers`Li Chen, Jun 10, 2025
  3. Junio C HamanoJun 11, 2025
  4. phillip.wood123@gmail.comJun 11, 2025
  5. Junio C HamanoJun 11, 2025
  6. Li ChenJun 12, 2025
  7. 2/2 rebase: support --trailerLi Chen, Jun 10, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.