From: Li Chen <me@linux.beauty>
Date: Thu, 12 Jun 2025 05:40:07 GMT
Subject: Re: [PATCH v2 1/2] trailer: append trailers in-process and drop the fork to `interpret-trailers`
Message-ID: <19762a71ab1.d16b43db461922.5615394257517989238@linux.beauty>
In-Reply-To: <xmqqa56ejnrk.fsf@gitster.g>

Hi Junio & Phillip,


 ---- On Wed, 11 Jun 2025 23:34:07 +0800  Junio C Hamano <gitster@pobox.com> wrote --- 
 > phillip.wood123@gmail.com writes:
 > 
 > > Exactly - I was expecting to see a refactoring of interpret_trailers()
 > > in builtin/interpret-trailers.c that moved most of the function body
 > > into a new function in trailer.c that added the trailers to an
 > > strbuf. This seems to be a parallel implementation which doesn't sound
 > > like the best plan.
 > >
 > > I'm going to be off the list for a couple of weeks, I'll take a more
 > > detailed look at this series when I'm back

Thanks for your suggestion; I will refactor it in the next version.

Regards,
Li