Re: [PATCH 00/18] Support symbolic links on Windows
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Dec 18, 2025, 18:51 UTC
- Message-ID
- <19030791-dafa-4a63-985b-9cdf423bfd1b@kdbg.org>
- In-Reply-To
- <pull.2018.git.1765980535.gitgitgadget@gmail.com>
Am 17.12.25 um 15:08 schrieb Johannes Schindelin via GitGitGadget:
Show 41 quoted lines
> This finally upstreams Git for Windows' support for Windows' branch of > symbolic links, which has been maturing since 2015. It is based off of > js/prep-symlink-windows. > > Bill Zissimopoulos (1): > mingw: compute the correct size for symlinks in `mingw_lstat()` > > Johannes Schindelin (3): > mingw: try to create symlinks without elevated permissions > mingw: emulate `stat()` a little more faithfully > mingw: special-case index entries for symlinks with buggy size > > Karsten Blees (14): > mingw: don't call `GetFileAttributes()` twice in `mingw_lstat()` > mingw: implement `stat()` with symlink support > mingw: drop the separate `do_lstat()` function > mingw: let `mingw_lstat()` error early upon problems with reparse > points > mingw: teach dirent about symlinks > mingw: factor out the retry logic > mingw: change default of `core.symlinks` to false > mingw: add symlink-specific error codes > mingw: handle symlinks to directories in `mingw_unlink()` > mingw: support renaming symlinks > mingw: allow `mingw_chdir()` to change to symlink-resolved directories > mingw: implement `readlink()` > mingw: implement basic `symlink()` functionality (file symlinks only) > mingw: add support for symlinks to directories > > compat/mingw-posix.h | 6 +- > compat/mingw.c | 635 ++++++++++++++++++++++++++++++++---------- > compat/win32.h | 6 +- > compat/win32/dirent.c | 5 +- > read-cache.c | 11 + > 5 files changed, 507 insertions(+), 156 deletions(-) > > > base-commit: 6f6fe02f5fe587ec9788f8a5a34281949d7b2ca1 > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2018%2Fdscho%2Fsymlinks-next-v1 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2018/dscho/symlinks-next-v1 > Pull-Request: https://github.com/gitgitgadget/git/pull/2018
I've reviewed this series and had a few comments on some of them.
All others look good, with one caveat though: symbolic links on Windows aren't exactly an itch of mine, and I'm unfamiliar with the corresponding API. That said, I didn't spot anything unusual at a superficial level.
I notice that Karsten's emails bounce. Would it be appropriate to redirect authorship and sign-off to the other email that is registered in .mailmap?
-- Hannes