git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add to gitk an --argscmd flag to get the list of refs to draw at refresh time.

From
Paul Mackerras <paulus@samba.org>
Date
Jul 22, 2007, 12:24 UTC
Message-ID
<18083.19607.236048.797818@cargo.ozlabs.ibm.com>
In-Reply-To
<20070712220411.31743.83101.stgit@gandelf.nowhere.earth>
Yann Dirson writes:
> This new version causes the command to add its revs to the litteral
> ones from command-line instead of overriding them, and allows to
> edit the command in the view editor.

Is it actually useful to use both the --argscmd flag and some literal revisions on the command line? Why would you use both?

Instead of the --argscmd flag, maybe we could have a convention that an argument starting with "|" is a command to run rather than a literal revision. Would that suit? It would seem to simplify the patch by eliminating the requirement for an extra entry field, as well as removing the need for the separate viewargscmd array.

> Disclaimer: I'm no tcl/tk expert, feel free to flame my style :)

There are a couple of things I think should be done differently, in fact. :)

Paul.
Previous: Yann DirsonNext: Yann Dirson
Message 2 of 3 in “Add to gitk an --argscmd flag to get the list of refs to draw at refresh time.”
  1. Add to gitk an --argscmd flag to get the list of refs to draw at refresh time.Yann Dirson, Jul 12, 2007
  2. Paul MackerrasJul 22, 2007
  3. Yann DirsonJul 22, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.