From: Paul Mackerras <paulus@samba.org>
Date: Sun, 22 Jul 2007 12:24:55 GMT
Subject: Re: [PATCH] Add to gitk an --argscmd flag to get the list of refs to draw at refresh time.
Message-ID: <18083.19607.236048.797818@cargo.ozlabs.ibm.com>
In-Reply-To: <20070712220411.31743.83101.stgit@gandelf.nowhere.earth>

Yann Dirson writes:

> This new version causes the command to add its revs to the litteral
> ones from command-line instead of overriding them, and allows to
> edit the command in the view editor.

Is it actually useful to use both the --argscmd flag and some literal
revisions on the command line?  Why would you use both?

Instead of the --argscmd flag, maybe we could have a convention that
an argument starting with "|" is a command to run rather than a
literal revision.  Would that suit?  It would seem to simplify the
patch by eliminating the requirement for an extra entry field, as well
as removing the need for the separate viewargscmd array.

> Disclaimer: I'm no tcl/tk expert, feel free to flame my style :)

There are a couple of things I think should be done differently, in
fact. :)

Paul.