Re: [PATCH] Add to gitk an --argscmd flag to get the list of refs to draw at refresh time.

From: Yann Dirson <ydirson@altern.org>
Date: Jul 22, 2007, 15:49 UTC
Message-ID: <20070722154903.GM23229@nan92-1-81-57-214-146.fbx.proxad.net>
In-Reply-To: <18083.19607.236048.797818@cargo.ozlabs.ibm.com>

On Sun, Jul 22, 2007 at 10:24:55PM +1000, Paul Mackerras wrote:

Show 8 quoted lines

> Yann Dirson writes:
> 
> > This new version causes the command to add its revs to the litteral
> > ones from command-line instead of overriding them, and allows to
> > edit the command in the view editor.
> 
> Is it actually useful to use both the --argscmd flag and some literal
> revisions on the command line?  Why would you use both?

I tend to mostly use --all each time I use gitk (or stg-gitk, for that matter), so my personal way of using gitk does not need it. However, it could be useful if someone launched, say, 'stg-gitk master', thus using --argscmd, and later wants to edit the view, eg. to add "origin".

> Instead of the --argscmd flag, maybe we could have a convention that
> an argument starting with "|" is a command to run rather than a
> literal revision.  Would that suit?

If we go that way, a final "|" could be more intuitive.

However, a final "|" would run into a limitation of the view editor, which is already a bit annoying with long command lines: the limited size of the text field would by default hide the important final char.

>  It would seem to simplify the
> patch by eliminating the requirement for an extra entry field, as well
> as removing the need for the separate viewargscmd array.

Sure, but at the same time, it does not make the code that more complicated, and it makes it obvious that there are 2 ways to specify the revs.

> > Disclaimer: I'm no tcl/tk expert, feel free to flame my style :)
> 
> There are a couple of things I think should be done differently, in
> fact. :)

Eh :)

Best regards,

-- 
Yann