git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: Fix nextfile() and add prevfile()

From
Paul Mackerras <paulus@samba.org>
Date
Sep 27, 2006, 00:15 UTC
Message-ID
<17689.49841.913304.878599@cargo.ozlabs.ibm.com>
In-Reply-To
<873bae3b5x.fsf_-_@duaron.myhome.or.jp>
OGAWA Hirofumi writes:
> The current nextfile() jumps to last hunk, but I think this is not
> intention, probably, it's forgetting to add "break;". And this
> patch also adds prevfile(), it jumps to previous hunk.

I think your prevfile isn't quite right - I don't think it will do the right thing if $loc is past the last entry in $difffilestart. Don't you want the "$ctext yview $prev" after the loop?

Paul.
Previous: OGAWA HirofumiNext: OGAWA Hirofumi
Message 6 of 7 in “gitk: Fix nextfile() and more”
  1. gitk: Fix nextfile() and moreOGAWA Hirofumi, Sep 25, 2006
  2. Junio C HamanoSep 26, 2006
  3. OGAWA HirofumiSep 26, 2006
  4. gitk: Fix nextfile() and add prevfile()OGAWA Hirofumi, Sep 26, 2006
  5. gitk: add some key-bindOGAWA Hirofumi, Sep 26, 2006
  6. Paul MackerrasSep 27, 2006
  7. OGAWA HirofumiSep 27, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.