git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitk: Fix nextfile() and add prevfile()

From
OHOGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Date
Sep 26, 2006, 15:22 UTC
Message-ID
<873bae3b5x.fsf_-_@duaron.myhome.or.jp>
In-Reply-To
<7vpsdjryj2.fsf@assigned-by-dhcp.cox.net>

The current nextfile() jumps to last hunk, but I think this is not intention, probably, it's forgetting to add "break;". And this patch also adds prevfile(), it jumps to previous hunk.

Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
---
 gitk |   14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff -puN gitk~gitk-nextfile-fix gitk --- git/gitk~gitk-nextfile-fix 2006-09-27 00:16:11.000000000 +0900 +++ git-hirofumi/gitk 2006-09-27 00:16:48.000000000 +0900

@@ -4440,12 +4440,26 @@ proc getblobdiffline {bdf ids} {
     }
 }
 
+proc prevfile {} {
+    global difffilestart ctext
+    set prev [lindex $difffilestart 0]
+    set here [$ctext index @0,0]
+    foreach loc $difffilestart {
+	if {[$ctext compare $loc >= $here]} {
+	    $ctext yview $prev
+	    break
+	}
+	set prev $loc
+    }
+}
+
 proc nextfile {} {
     global difffilestart ctext
     set here [$ctext index @0,0]
     foreach loc $difffilestart {
 	if {[$ctext compare $loc > $here]} {
 	    $ctext yview $loc
+	    break
 	}
     }
 }
_
Previous: OGAWA HirofumiNext: OGAWA Hirofumi
Message 4 of 7 in “gitk: Fix nextfile() and more”
  1. gitk: Fix nextfile() and moreOGAWA Hirofumi, Sep 25, 2006
  2. Junio C HamanoSep 26, 2006
  3. OGAWA HirofumiSep 26, 2006
  4. gitk: Fix nextfile() and add prevfile()OGAWA Hirofumi, Sep 26, 2006
  5. gitk: add some key-bindOGAWA Hirofumi, Sep 26, 2006
  6. Paul MackerrasSep 27, 2006
  7. OGAWA HirofumiSep 27, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.