From: Paul Mackerras Date: Wed, 27 Sep 2006 00:15:45 GMT Subject: Re: [PATCH] gitk: Fix nextfile() and add prevfile() Message-ID: <17689.49841.913304.878599@cargo.ozlabs.ibm.com> In-Reply-To: <873bae3b5x.fsf_-_@duaron.myhome.or.jp> OGAWA Hirofumi writes: > The current nextfile() jumps to last hunk, but I think this is not > intention, probably, it's forgetting to add "break;". And this > patch also adds prevfile(), it jumps to previous hunk. I think your prevfile isn't quite right - I don't think it will do the right thing if $loc is past the last entry in $difffilestart. Don't you want the "$ctext yview $prev" after the loop? Paul.