git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 07/11] completion: bash: cleanup cygwin check

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 20, 2016, 04:58 UTC
Message-ID
<1463720325-8853-8-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1463720325-8853-1-git-send-email-felipe.contreras@gmail.com>
Avoid Yoda conditions, use test, and cleaner statement.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/completion/git-completion.bash | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 6c338ae..398f3a7 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -2698,6 +2698,5 @@ __git_complete gitk __gitk_main
 # when the user has tab-completed the executable name and consequently
 # included the '.exe' suffix.
 #
-if [ Cygwin = "$(uname -o 2>/dev/null)" ]; then
+test "$(uname -o 2>/dev/null)" = "Cygwin" &&
 __git_complete git.exe __git_main
-fi
-- 
2.8.0+fc1
Previous: Felipe ContrerasNext: Felipe Contreras
Message 8 of 12 in “Completion fixes and improvements”
  1. 00/11 Completion fixes and improvementsFelipe Contreras, May 20, 2016
  2. 01/11 completion: add missing fetch optionsFelipe Contreras, May 20, 2016
  3. 02/11 completion: bash: remove old wrappersFelipe Contreras, May 20, 2016
  4. 03/11 completion: bash: remove zsh wrapperFelipe Contreras, May 20, 2016
  5. 04/11 completion: zsh: don't hide ourselvesFelipe Contreras, May 20, 2016
  6. 05/11 completion: remove zsh hackFelipe Contreras, May 20, 2016
  7. 06/11 completion: zsh: trivial cleanupsFelipe Contreras, May 20, 2016
  8. 07/11 completion: bash: cleanup cygwin checkFelipe Contreras, May 20, 2016
  9. 08/11 completion: zsh: improve main function selectionFelipe Contreras, May 20, 2016
  10. 09/11 completion: zsh: fix for directories with spacesFelipe Contreras, May 20, 2016
  11. 10/11 completion: prompt: fix for ZshFelipe Contreras, May 20, 2016
  12. 11/11 Revert "Update documentation occurrences of filename .sh"Felipe Contreras, May 20, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.