git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 05/11] completion: remove zsh hack

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 20, 2016, 04:58 UTC
Message-ID
<1463720325-8853-6-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1463720325-8853-1-git-send-email-felipe.contreras@gmail.com>

We don't want to override the 'complete()' function in zsh, which can be used by bashcomp.

Reported-by: Mark Lodato <lodato@google.com>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/completion/git-completion.bash | 1 +
 contrib/completion/git-completion.zsh  | 6 ------
 2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 9cbae6f..6c338ae 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -2684,6 +2684,7 @@ __git_func_wrap ()
 # This is NOT a public function; use at your own risk.
 __git_complete ()
 {
+	test -n "$ZSH_VERSION" && return
 	local wrapper="__git_wrap${2}"
 	eval "$wrapper () { __git_func_wrap $2 ; }"
 	complete -o bashdefault -o default -o nospace -F $wrapper $1 2>/dev/null \
diff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh
index 475705a..e10df7d 100644
--- a/contrib/completion/git-completion.zsh
+++ b/contrib/completion/git-completion.zsh
@@ -16,12 +16,6 @@
 #
 #  fpath=(~/.zsh $fpath)
 
-complete ()
-{
-	# do nothing
-	return 0
-}
-
 zstyle -T ':completion:*:*:git:*' tag-order && \
 	zstyle ':completion:*:*:git:*' tag-order 'common-commands'
 
-- 
2.8.0+fc1
Previous: Felipe ContrerasNext: Felipe Contreras
Message 6 of 12 in “Completion fixes and improvements”
  1. 00/11 Completion fixes and improvementsFelipe Contreras, May 20, 2016
  2. 01/11 completion: add missing fetch optionsFelipe Contreras, May 20, 2016
  3. 02/11 completion: bash: remove old wrappersFelipe Contreras, May 20, 2016
  4. 03/11 completion: bash: remove zsh wrapperFelipe Contreras, May 20, 2016
  5. 04/11 completion: zsh: don't hide ourselvesFelipe Contreras, May 20, 2016
  6. 05/11 completion: remove zsh hackFelipe Contreras, May 20, 2016
  7. 06/11 completion: zsh: trivial cleanupsFelipe Contreras, May 20, 2016
  8. 07/11 completion: bash: cleanup cygwin checkFelipe Contreras, May 20, 2016
  9. 08/11 completion: zsh: improve main function selectionFelipe Contreras, May 20, 2016
  10. 09/11 completion: zsh: fix for directories with spacesFelipe Contreras, May 20, 2016
  11. 10/11 completion: prompt: fix for ZshFelipe Contreras, May 20, 2016
  12. 11/11 Revert "Update documentation occurrences of filename .sh"Felipe Contreras, May 20, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.