git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 11/11] Revert "Update documentation occurrences of filename .sh"

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 20, 2016, 04:58 UTC
Message-ID
<1463720325-8853-12-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1463720325-8853-1-git-send-email-felipe.contreras@gmail.com>

The original code was correct: the example location ~/.git-completion.sh is correct, because it's not only used by Bash. And zstyle command in Zsh should use that same location; the Bash script.

This reverts commit 0e5ed7cca3c51c821c2bb0465617e75d994f432f.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/completion/git-completion.bash | 4 ++--
 contrib/completion/git-completion.zsh  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 398f3a7..3224ae1 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -17,9 +17,9 @@
 #
 # To use these routines:
 #
-#    1) Copy this file to somewhere (e.g. ~/.git-completion.bash).
+#    1) Copy this file to somewhere (e.g. ~/.git-completion.sh).
 #    2) Add the following line to your .bashrc/.zshrc:
-#        source ~/.git-completion.bash
+#        source ~/.git-completion.sh
 #    3) Consider changing your PS1 to also show the current branch,
 #       see git-prompt.sh for details.
 #
diff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh
index 28eaaed..6075111 100644
--- a/contrib/completion/git-completion.zsh
+++ b/contrib/completion/git-completion.zsh
@@ -9,7 +9,7 @@
 #
 # If your script is somewhere else, you can configure it on your ~/.zshrc:
 #
-#  zstyle ':completion:*:*:git:*' script ~/.git-completion.zsh
+#  zstyle ':completion:*:*:git:*' script ~/.git-completion.sh
 #
 # The recommended way to install this script is to copy to '~/.zsh/_git', and
 # then add the following to your ~/.zshrc file:
-- 
2.8.0+fc1
Previous: Felipe Contreras
Message 12 of 12 in “Completion fixes and improvements”
  1. 00/11 Completion fixes and improvementsFelipe Contreras, May 20, 2016
  2. 01/11 completion: add missing fetch optionsFelipe Contreras, May 20, 2016
  3. 02/11 completion: bash: remove old wrappersFelipe Contreras, May 20, 2016
  4. 03/11 completion: bash: remove zsh wrapperFelipe Contreras, May 20, 2016
  5. 04/11 completion: zsh: don't hide ourselvesFelipe Contreras, May 20, 2016
  6. 05/11 completion: remove zsh hackFelipe Contreras, May 20, 2016
  7. 06/11 completion: zsh: trivial cleanupsFelipe Contreras, May 20, 2016
  8. 07/11 completion: bash: cleanup cygwin checkFelipe Contreras, May 20, 2016
  9. 08/11 completion: zsh: improve main function selectionFelipe Contreras, May 20, 2016
  10. 09/11 completion: zsh: fix for directories with spacesFelipe Contreras, May 20, 2016
  11. 10/11 completion: prompt: fix for ZshFelipe Contreras, May 20, 2016
  12. 11/11 Revert "Update documentation occurrences of filename .sh"Felipe Contreras, May 20, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.