git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC 2/6] remote-curl.c: fix variable shadowing

From
David Turner <dturner@twopensource.com>
Date
Apr 19, 2016, 19:14 UTC
Message-ID
<1461093271.5540.110.camel@twopensource.com>
In-Reply-To
<xmqqega26a01.fsf@gitster.mtv.corp.google.com>
On Mon, 2016-04-18 at 11:35 -0700, Junio C Hamano wrote:
Show 10 quoted lines
> David Turner <dturner@twopensource.com> writes:
> 
> > The local variable 'options' was shadowing a global of the same
> > name.
> > 
> > Signed-off-by: David Turner <dturner@twopensource.com>
> > ---
> 
> OK.  In general, giving a longer and more descriptive name to the
> global would be a direction to lead to more readable code, though.
OK, will do that instead.
Previous: Junio C HamanoNext: David Turner
Message 7 of 36 in “fetch with refspec”
  1. 0/6 fetch with refspecDavid Turner, Apr 15, 2016
  2. 1/6 http-backend: use argv_array functionsDavid Turner, Apr 15, 2016
  3. Junio C HamanoApr 18, 2016
  4. David TurnerApr 19, 2016
  5. 2/6 remote-curl.c: fix variable shadowingDavid Turner, Apr 15, 2016
  6. Junio C HamanoApr 18, 2016
  7. David TurnerApr 19, 2016
  8. 3/6 http-backend: handle refspec argumentDavid Turner, Apr 15, 2016
  9. Eric SunshineApr 17, 2016
  10. David TurnerApr 19, 2016
  11. 4/6 transport: add refspec list parameters to functionsDavid Turner, Apr 15, 2016
  12. Junio C HamanoApr 18, 2016
  13. Jeff KingApr 19, 2016
  14. Stefan BellerApr 19, 2016
  15. Junio C HamanoApr 19, 2016
  16. David TurnerApr 19, 2016
  17. Jeff KingApr 19, 2016
  18. David TurnerApr 19, 2016
  19. Jeff KingApr 20, 2016
  20. David TurnerApr 20, 2016
  21. Jeff KingApr 20, 2016
  22. David TurnerApr 25, 2016
  23. Stefan BellerApr 25, 2016
  24. Stefan BellerApr 27, 2016
  25. Jeff KingApr 27, 2016
  26. Junio C HamanoApr 27, 2016
  27. David TurnerApr 29, 2016
  28. Stefan BellerApr 29, 2016
  29. David TurnerApr 19, 2016
  30. 5/6 fetch: pass refspec to http serverDavid Turner, Apr 15, 2016
  31. Eric SunshineApr 17, 2016
  32. David TurnerApr 19, 2016
  33. 6/6 clone: send refspec for single-branch clonesDavid Turner, Apr 15, 2016
  34. Eric SunshineApr 17, 2016
  35. David TurnerApr 19, 2016
  36. Stefan BellerApr 15, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.