From: David Turner <dturner@twopensource.com>
Date: Tue, 19 Apr 2016 19:14:31 GMT
Subject: Re: [PATCH/RFC 2/6] remote-curl.c: fix variable shadowing
Message-ID: <1461093271.5540.110.camel@twopensource.com>
In-Reply-To: <xmqqega26a01.fsf@gitster.mtv.corp.google.com>

On Mon, 2016-04-18 at 11:35 -0700, Junio C Hamano wrote:
> David Turner <dturner@twopensource.com> writes:
> 
> > The local variable 'options' was shadowing a global of the same
> > name.
> > 
> > Signed-off-by: David Turner <dturner@twopensource.com>
> > ---
> 
> OK.  In general, giving a longer and more descriptive name to the
> global would be a direction to lead to more readable code, though.

OK, will do that instead.