git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC 4/6] transport: add refspec list parameters to functions

From
David Turner <dturner@twopensource.com>
Date
Apr 20, 2016, 20:46 UTC
Message-ID
<1461185215.5540.180.camel@twopensource.com>
In-Reply-To
<20160420011740.GA29839@sigill.intra.peff.net>
On Tue, 2016-04-19 at 21:17 -0400, Jeff King wrote:
Show 41 quoted lines
> On Tue, Apr 19, 2016 at 07:43:11PM -0400, David Turner wrote:
> 
> > On Tue, 2016-04-19 at 19:22 -0400, Jeff King wrote:
> > > You can find previous discussion on the list, but I think the
> > > options
> > > basically are:
> > > 
> > >   1. Something like v2, where the client gets a chance to speak
> > > before
> > >      the advertisement.
> > > 
> > >   2. Some out-of-band way of getting values from the client to
> > > the
> > >      server (so maybe extra command-line arguments for git-over
> > > -ssh,
> > > and
> > >      maybe shoving something after the "\0" for git-daemon, and
> > > of
> > >      course extra parameters for HTTP).
> > > 
> > >   3. The client saying "stop spewing refs at me, I want to give
> > > you a
> > >      ref filter" asynchronously, and accepting a little spew at
> > > the
> > >      beginning of each conversation. That obviously only works
> > > for
> > > the
> > >      full-duplex transports, so you'd probably fall back to (2)
> > > for
> > >      http.
> > 
> > OK, so (2) seems like what I'm doing -- it just happens that I only
> > implemented it for one protocol.
> 
> Right. And I don't mind that approach _if_ we can figure out a way to
> do
> it for all protocols. But I think there are some complications with
> the
> other ones, which means that HTTP will have the ability to grow
> features
> the other protocols do not.

As you note, it appears that git-daemon does sort-of have support for extra args -- see parse_host_arg. So it wouldn't be hard to add something here. Unfortunately, current versions of git die on unknown args. So this change would not be backwards-compatible. We could put a decider on it so that clients would only try it when explicitly enabled. Or we could have clients try it with, and in the event of an error, retry without. Neither is ideal, but both are possible.

If I read this code correctly, git-over-ssh will pass through arbitrary arguments. So this should be trivial.

Previous: Jeff KingNext: Jeff King
Message 20 of 36 in “fetch with refspec”
  1. 0/6 fetch with refspecDavid Turner, Apr 15, 2016
  2. 1/6 http-backend: use argv_array functionsDavid Turner, Apr 15, 2016
  3. Junio C HamanoApr 18, 2016
  4. David TurnerApr 19, 2016
  5. 2/6 remote-curl.c: fix variable shadowingDavid Turner, Apr 15, 2016
  6. Junio C HamanoApr 18, 2016
  7. David TurnerApr 19, 2016
  8. 3/6 http-backend: handle refspec argumentDavid Turner, Apr 15, 2016
  9. Eric SunshineApr 17, 2016
  10. David TurnerApr 19, 2016
  11. 4/6 transport: add refspec list parameters to functionsDavid Turner, Apr 15, 2016
  12. Junio C HamanoApr 18, 2016
  13. Jeff KingApr 19, 2016
  14. Stefan BellerApr 19, 2016
  15. Junio C HamanoApr 19, 2016
  16. David TurnerApr 19, 2016
  17. Jeff KingApr 19, 2016
  18. David TurnerApr 19, 2016
  19. Jeff KingApr 20, 2016
  20. David TurnerApr 20, 2016
  21. Jeff KingApr 20, 2016
  22. David TurnerApr 25, 2016
  23. Stefan BellerApr 25, 2016
  24. Stefan BellerApr 27, 2016
  25. Jeff KingApr 27, 2016
  26. Junio C HamanoApr 27, 2016
  27. David TurnerApr 29, 2016
  28. Stefan BellerApr 29, 2016
  29. David TurnerApr 19, 2016
  30. 5/6 fetch: pass refspec to http serverDavid Turner, Apr 15, 2016
  31. Eric SunshineApr 17, 2016
  32. David TurnerApr 19, 2016
  33. 6/6 clone: send refspec for single-branch clonesDavid Turner, Apr 15, 2016
  34. Eric SunshineApr 17, 2016
  35. David TurnerApr 19, 2016
  36. Stefan BellerApr 15, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.