Re: [PATCH v5 25/27] refs: add LMDB refs storage backend

From: David Turner <dturner@twopensource.com>
Date: Feb 24, 2016, 20:41 UTC
Message-ID: <1456346510.18017.21.camel@twopensource.com>
In-Reply-To: <CACsJy8Ci_U+=Nw+9mzebQ1w3xtvb_=TZKyKC4nkRMPjhwDQ-mg@mail.gmail.com>

On Sat, 2016-02-20 at 20:14 +0700, Duy Nguyen wrote:

Show 24 quoted lines

> On Fri, Feb 19, 2016 at 3:23 AM, David Turner <
> dturner@twopensource.com> wrote:
> > On Thu, 2016-02-18 at 15:50 +0700, Duy Nguyen wrote:
> > 
> > [snip]
> > 
> > Thanks; applied the above
> > 
> > > This permission makes me wonder if we need adjust_shared_perm()
> > > here
> > > and some other places.
> > 
> > So just add this after every mkdir?
> > 
> >         if (shared_repository)
> >                 adjust_shared_perm(db_path);
> > 
> 
> Another option is avoid mkdir entirely. Getting started page [1] says
> if you do mdb_open_env(.., "refs.lmdb", MDB_NOSUBDIR,..) then it will
> create two files refs.lmdb and refs.lmdb.lock. No need for the
> directory "refs.lmdb" just to contain two files.
> 
> [1] http://symas.com/mdb/doc/starting.html

Good idea.