Re: [PATCH v5 23/27] svn: learn ref-storage argument

From: David Turner <dturner@twopensource.com>
Date: Feb 23, 2016, 18:08 UTC
Message-ID: <1456250903.7528.105.camel@twopensource.com>
In-Reply-To: <20160220235514.GA2311@dcvr.yhbt.net>

On Sat, 2016-02-20 at 23:55 +0000, Eric Wong wrote:

Show 10 quoted lines

> David Turner <dturner@twopensource.com> wrote:
> > +++ b/git-svn.perl
> 
> > +		if (defined $_ref_storage) {
> > +		    push @init_db, "--ref-storage=" .
> > $_ref_storage;
> > +		}
> 
> Minor nit: git-svn uses tabs for indentation.
> Otherwise, if we go this route, consider it:

Got it, thanks.

Show 6 quoted lines

> Signed-off-by: Eric Wong <normalperson@yhbt.net>
> 
> Thanks.
> 
> I would favor Shawn's RefTree or similar to reuse existing
> code + commands and avoid the external dependency, though.

It's an interesting idea. I'm not sure how good the performance would be in the case where there are a large number of refs in a single directory, but it would be worth a try.