git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 01/13] refs: move REF_DELETING to refs.c

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Feb 17, 2015, 17:00 UTC
Message-ID
<1424192423-27979-2-git-send-email-mhagger@alum.mit.edu>
In-Reply-To
<1424192423-27979-1-git-send-email-mhagger@alum.mit.edu>
It is only used internally now. Document it a little bit better, too.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Reviewed-by: Stefan Beller <sbeller@google.com>
---
 refs.c | 6 ++++++
 refs.h | 4 +---
 2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/refs.c b/refs.c
index ab2f2a9..5e6355c 100644
--- a/refs.c
+++ b/refs.c
@@ -35,6 +35,12 @@ static unsigned char refname_disposition[256] = {
 };
 
 /*
+ * Flag passed to lock_ref_sha1_basic() telling it to tolerate broken
+ * refs (i.e., because the reference is about to be deleted anyway).
+ */
+#define REF_DELETING	0x02
+
+/*
  * Used as a flag to ref_transaction_delete when a loose ref is being
  * pruned.
  */
diff --git a/refs.h b/refs.h
index afa3c4d..9bf2148 100644
--- a/refs.h
+++ b/refs.h
@@ -183,12 +183,10 @@ extern int peel_ref(const char *refname, unsigned char *sha1);
  * Flags controlling ref_transaction_update(), ref_transaction_create(), etc.
  * REF_NODEREF: act on the ref directly, instead of dereferencing
  *              symbolic references.
- * REF_DELETING: tolerate broken refs
  *
- * Flags >= 0x100 are reserved for internal use.
+ * Other flags are reserved for internal use.
  */
 #define REF_NODEREF	0x01
-#define REF_DELETING	0x02
 
 /*
  * Setup reflog before using. Set errno to something meaningful on failure.
-- 
2.1.4
Previous: Michael HaggertyNext: Michael Haggerty
Message 2 of 15 in “Allow reference values to be checked in a transaction”
  1. 00/13 Allow reference values to be checked in a transactionMichael Haggerty, Feb 17, 2015
  2. 01/13 refs: move REF_DELETING to refs.cMichael Haggerty, Feb 17, 2015
  3. 02/13 refs: remove the gap in the REF_* constant valuesMichael Haggerty, Feb 17, 2015
  4. 03/13 refs.c: Change some "flags" to "unsigned int"Michael Haggerty, Feb 17, 2015
  5. 04/13 struct ref_update: move "have_old" into "flags"Michael Haggerty, Feb 17, 2015
  6. 05/13 ref_transaction_update(): remove "have_old" parameterMichael Haggerty, Feb 17, 2015
  7. 06/13 ref_transaction_delete(): remove "have_old" parameterMichael Haggerty, Feb 17, 2015
  8. 07/13 commit: add tests of commit racesMichael Haggerty, Feb 17, 2015
  9. 08/13 commit: avoid race when creating orphan commitsMichael Haggerty, Feb 17, 2015
  10. 09/13 ref_transaction_create(): check that new_sha1 is validMichael Haggerty, Feb 17, 2015
  11. 10/13 ref_transaction_delete(): check that old_sha1 is not null_sha1Michael Haggerty, Feb 17, 2015
  12. 11/13 ref_transaction_verify(): new function to check a reference's valueMichael Haggerty, Feb 17, 2015
  13. 12/13 update_ref(): improve documentationMichael Haggerty, Feb 17, 2015
  14. 13/13 refs.h: Remove duplication in function docstringsMichael Haggerty, Feb 17, 2015
  15. Junio C HamanoFeb 17, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.