[PATCH v3 09/13] ref_transaction_create(): check that new_sha1 is valid

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Feb 17, 2015, 17:00 UTC
Message-ID: <1424192423-27979-10-git-send-email-mhagger@alum.mit.edu>
In-Reply-To: <1424192423-27979-1-git-send-email-mhagger@alum.mit.edu>

Creating a reference requires a new_sha1 that is not NULL and not null_sha1.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Reviewed-by: Stefan Beller <sbeller@google.com>
---
 refs.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/refs.c b/refs.c
index e3c4ab5..b9cf284 100644
--- a/refs.c
+++ b/refs.c
@@ -3690,6 +3690,8 @@ int ref_transaction_create(struct ref_transaction *transaction,
 			   unsigned int flags, const char *msg,
 			   struct strbuf *err)
 {
+	if (!new_sha1 || is_null_sha1(new_sha1))
+		die("BUG: create called without valid new_sha1");
 	return ref_transaction_update(transaction, refname, new_sha1,
 				      null_sha1, flags, msg, err);
 }

-- 
2.1.4