[PATCH v6 07/39] lockfile: unlock file if lockfile permissions cannot be adjusted

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Sep 26, 2014, 10:08 UTC
Message-ID: <1411726119-31598-8-git-send-email-mhagger@alum.mit.edu>
In-Reply-To: <1411726119-31598-1-git-send-email-mhagger@alum.mit.edu>

If the call to adjust_shared_perm() fails, lock_file returns -1, which to the caller looks like any other failure to lock the file. So in this case, roll back the lockfile before returning so that the lock file is deleted immediately and the lockfile object is left in a predictable state (namely, unlocked). Previously, the lockfile was retained until process cleanup in this situation.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
---
 lockfile.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lockfile.c b/lockfile.c
index 3df1e83..d74de8d 100644
--- a/lockfile.c
+++ b/lockfile.c
@@ -153,6 +153,7 @@ static int lock_file(struct lock_file *lk, const char *path, int flags)
 			int save_errno = errno;
 			error("cannot fix permission bits on %s",
 			      lk->filename);
+			rollback_lock_file(lk);
 			errno = save_errno;
 			return -1;
 		}

-- 
2.1.0