git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 03/22] refs-common.c: move update_ref to refs-common.c

From
Ronnie Sahlberg <sahlberg@google.com>
Date
Aug 8, 2014, 16:44 UTC
Message-ID
<1407516309-27989-4-git-send-email-sahlberg@google.com>
In-Reply-To
<1407516309-27989-1-git-send-email-sahlberg@google.com>

This change moves update_ref() to the refs-common.c file since this function does not contain any backend specific code.

Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
---
 refs-common.c | 25 +++++++++++++++++++++++++
 refs.c        | 23 -----------------------
 2 files changed, 25 insertions(+), 23 deletions(-)
diff --git a/refs-common.c b/refs-common.c
index 44d96d2..cb884b2 100644
--- a/refs-common.c
+++ b/refs-common.c
@@ -1,2 +1,27 @@
 /* common code for all ref backends */
+#include "cache.h"
+#include "refs.h"
+
+int update_ref(const char *action, const char *refname,
+	       const unsigned char *sha1, const unsigned char *oldval,
+	       int flags, struct strbuf *e)
+{
+	struct ref_transaction *t;
+	struct strbuf err = STRBUF_INIT;
+
+	t = transaction_begin(&err);
+	if (!t ||
+	    transaction_update_sha1(t, refname, sha1, oldval, flags,
+				    !!oldval, action, &err) ||
+	    transaction_commit(t, &err)) {
+		const char *str = "update_ref failed for ref '%s': %s";
+
+		transaction_free(t);
+		if (e)
+			strbuf_addf(e, str, refname, err.buf);
+		strbuf_release(&err);
+		return 1;
+	}
+	return 0;
+}
 
diff --git a/refs.c b/refs.c
index 4a22513..eb66cf7 100644
--- a/refs.c
+++ b/refs.c
@@ -3576,29 +3576,6 @@ int transaction_delete_sha1(struct ref_transaction *transaction,
 				      old_sha1, flags, have_old, msg, err);
 }
 
-int update_ref(const char *action, const char *refname,
-	       const unsigned char *sha1, const unsigned char *oldval,
-	       int flags, struct strbuf *e)
-{
-	struct ref_transaction *t;
-	struct strbuf err = STRBUF_INIT;
-
-	t = transaction_begin(&err);
-	if (!t ||
-	    transaction_update_sha1(t, refname, sha1, oldval, flags,
-				    !!oldval, action, &err) ||
-	    transaction_commit(t, &err)) {
-		const char *str = "update_ref failed for ref '%s': %s";
-
-		transaction_free(t);
-		if (e)
-			strbuf_addf(e, str, refname, err.buf);
-		strbuf_release(&err);
-		return 1;
-	}
-	return 0;
-}
-
 static int ref_update_compare(const void *r1, const void *r2)
 {
 	const struct ref_update * const *u1 = r1;
-- 
2.0.1.553.geee1b3e
Previous: Ronnie SahlbergNext: Ronnie Sahlberg
Message 6 of 26 in “backend-struct-db”
  1. 00/22 backend-struct-dbRonnie Sahlberg, Aug 8, 2014
  2. 01/22 refs.c: create a public function for is_refname_availableRonnie Sahlberg, Aug 8, 2014
  3. David TurnerAug 8, 2014
  4. Ronnie SahlbergAug 11, 2014
  5. 02/22 refs-common.c: create a file to host all common refs codeRonnie Sahlberg, Aug 8, 2014
  6. 03/22 refs-common.c: move update_ref to refs-common.cRonnie Sahlberg, Aug 8, 2014
  7. 04/22 refs-common.c: move delete_ref to the common codeRonnie Sahlberg, Aug 8, 2014
  8. 05/22 refs-common.c: move rename_ref to the common codeRonnie Sahlberg, Aug 8, 2014
  9. 06/22 refs-common.c: move read_ref_at to the refs common fileRonnie Sahlberg, Aug 8, 2014
  10. 07/22 refs-common.c: move the hidden refs functions to the common codeRonnie Sahlberg, Aug 8, 2014
  11. 08/22 refs-common.c: move dwim and friend functions to refs commonRonnie Sahlberg, Aug 8, 2014
  12. 09/22 refs-common.c: move warn_if_dangling_symref* to refs-commonRonnie Sahlberg, Aug 8, 2014
  13. 10/22 refs-common.c: move read_ref, read_ref_full and ref_exists to commonRonnie Sahlberg, Aug 8, 2014
  14. 11/22 refs-common.c: move resolve_refdup to commonRonnie Sahlberg, Aug 8, 2014
  15. 12/22 refs-common.c: move check_refname_component to the common codeRonnie Sahlberg, Aug 8, 2014
  16. 13/22 refs-common.c: move is_branch to the common codeRonnie Sahlberg, Aug 8, 2014
  17. 14/22 refs-common.c: move names_conflict to the common codeRonnie Sahlberg, Aug 8, 2014
  18. 15/22 refs-common.c: move prettify_refname to the common codeRonnie Sahlberg, Aug 8, 2014
  19. 16/22 refs-common.c: move ref iterators to the common codeRonnie Sahlberg, Aug 8, 2014
  20. 17/22 refs.c: add a backend method structure with transaction functionsRonnie Sahlberg, Aug 8, 2014
  21. David TurnerAug 8, 2014
  22. Ronnie SahlbergAug 11, 2014
  23. 18/22 refs.c: add reflog backend methodsRonnie Sahlberg, Aug 8, 2014
  24. 19/22 refs.c: add methods for misc ref operationsRonnie Sahlberg, Aug 8, 2014
  25. 20/22 refs.c: add methods for head_ref*Ronnie Sahlberg, Aug 8, 2014
  26. 21/22 refs.c: add methods for the ref iteratorsRonnie Sahlberg, Aug 8, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.