git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 14/22] refs-common.c: move names_conflict to the common code

From
Ronnie Sahlberg <sahlberg@google.com>
Date
Aug 8, 2014, 16:45 UTC
Message-ID
<1407516309-27989-15-git-send-email-sahlberg@google.com>
In-Reply-To
<1407516309-27989-1-git-send-email-sahlberg@google.com>
Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
---
 refs-common.c |  8 ++++++++
 refs.c        | 14 --------------
 refs.h        |  9 +++++++++
 3 files changed, 17 insertions(+), 14 deletions(-)
diff --git a/refs-common.c b/refs-common.c
index 5f83d7e..6eef80b 100644
--- a/refs-common.c
+++ b/refs-common.c
@@ -3,6 +3,14 @@
 #include "refs.h"
 #include "string-list.h"
 
+int names_conflict(const char *refname1, const char *refname2)
+{
+	for (; *refname1 && *refname1 == *refname2; refname1++, refname2++)
+		;
+	return (*refname1 == '\0' && *refname2 == '/')
+		|| (*refname1 == '/' && *refname2 == '\0');
+}
+
 int is_branch(const char *refname)
 {
 	return !strcmp(refname, "HEAD") || starts_with(refname, "refs/heads/");
diff --git a/refs.c b/refs.c
index 70c034c..6542969 100644
--- a/refs.c
+++ b/refs.c
@@ -676,20 +676,6 @@ static void prime_ref_dir(struct ref_dir *dir)
 			prime_ref_dir(get_ref_dir(entry));
 	}
 }
-/*
- * Return true iff refname1 and refname2 conflict with each other.
- * Two reference names conflict if one of them exactly matches the
- * leading components of the other; e.g., "foo/bar" conflicts with
- * both "foo" and with "foo/bar/baz" but not with "foo/bar" or
- * "foo/barbados".
- */
-static int names_conflict(const char *refname1, const char *refname2)
-{
-	for (; *refname1 && *refname1 == *refname2; refname1++, refname2++)
-		;
-	return (*refname1 == '\0' && *refname2 == '/')
-		|| (*refname1 == '/' && *refname2 == '\0');
-}
 
 struct name_conflict_cb {
 	const char *refname;
diff --git a/refs.h b/refs.h
index 7b59044..5577824 100644
--- a/refs.h
+++ b/refs.h
@@ -128,6 +128,15 @@ int pack_refs(unsigned int flags, struct strbuf *err);
 
 extern int ref_exists(const char *);
 
+/*
+ * Return true iff refname1 and refname2 conflict with each other.
+ * Two reference names conflict if one of them exactly matches the
+ * leading components of the other; e.g., "foo/bar" conflicts with
+ * both "foo" and with "foo/bar/baz" but not with "foo/bar" or
+ * "foo/barbados".
+ */
+int names_conflict(const char *refname1, const char *refname2);
+
 extern int is_branch(const char *refname);
 
 /*
-- 
2.0.1.553.geee1b3e
Previous: Ronnie SahlbergNext: Ronnie Sahlberg
Message 17 of 26 in “backend-struct-db”
  1. 00/22 backend-struct-dbRonnie Sahlberg, Aug 8, 2014
  2. 01/22 refs.c: create a public function for is_refname_availableRonnie Sahlberg, Aug 8, 2014
  3. David TurnerAug 8, 2014
  4. Ronnie SahlbergAug 11, 2014
  5. 02/22 refs-common.c: create a file to host all common refs codeRonnie Sahlberg, Aug 8, 2014
  6. 03/22 refs-common.c: move update_ref to refs-common.cRonnie Sahlberg, Aug 8, 2014
  7. 04/22 refs-common.c: move delete_ref to the common codeRonnie Sahlberg, Aug 8, 2014
  8. 05/22 refs-common.c: move rename_ref to the common codeRonnie Sahlberg, Aug 8, 2014
  9. 06/22 refs-common.c: move read_ref_at to the refs common fileRonnie Sahlberg, Aug 8, 2014
  10. 07/22 refs-common.c: move the hidden refs functions to the common codeRonnie Sahlberg, Aug 8, 2014
  11. 08/22 refs-common.c: move dwim and friend functions to refs commonRonnie Sahlberg, Aug 8, 2014
  12. 09/22 refs-common.c: move warn_if_dangling_symref* to refs-commonRonnie Sahlberg, Aug 8, 2014
  13. 10/22 refs-common.c: move read_ref, read_ref_full and ref_exists to commonRonnie Sahlberg, Aug 8, 2014
  14. 11/22 refs-common.c: move resolve_refdup to commonRonnie Sahlberg, Aug 8, 2014
  15. 12/22 refs-common.c: move check_refname_component to the common codeRonnie Sahlberg, Aug 8, 2014
  16. 13/22 refs-common.c: move is_branch to the common codeRonnie Sahlberg, Aug 8, 2014
  17. 14/22 refs-common.c: move names_conflict to the common codeRonnie Sahlberg, Aug 8, 2014
  18. 15/22 refs-common.c: move prettify_refname to the common codeRonnie Sahlberg, Aug 8, 2014
  19. 16/22 refs-common.c: move ref iterators to the common codeRonnie Sahlberg, Aug 8, 2014
  20. 17/22 refs.c: add a backend method structure with transaction functionsRonnie Sahlberg, Aug 8, 2014
  21. David TurnerAug 8, 2014
  22. Ronnie SahlbergAug 11, 2014
  23. 18/22 refs.c: add reflog backend methodsRonnie Sahlberg, Aug 8, 2014
  24. 19/22 refs.c: add methods for misc ref operationsRonnie Sahlberg, Aug 8, 2014
  25. 20/22 refs.c: add methods for head_ref*Ronnie Sahlberg, Aug 8, 2014
  26. 21/22 refs.c: add methods for the ref iteratorsRonnie Sahlberg, Aug 8, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.