git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 17/22] refs.c: add a backend method structure with transaction functions

From
Ronnie Sahlberg <sahlberg@google.com>
Date
Aug 8, 2014, 16:45 UTC
Message-ID
<1407516309-27989-18-git-send-email-sahlberg@google.com>
In-Reply-To
<1407516309-27989-1-git-send-email-sahlberg@google.com>

Add a ref structure for backend methods. Start by adding method pointers for the transaction functions.

Rename the existing transaction functions to files_* and make them static. Add new transaction functions that just pass through to the appropriate methods for the backend.

Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
---
 refs-common.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++
 refs.c        | 68 +++++++++++++++++++++++++++++++++++------------------------
 refs.h        | 35 ++++++++++++++++++++++++++++++
 3 files changed, 130 insertions(+), 27 deletions(-)
diff --git a/refs-common.c b/refs-common.c
index 3b20db3..d4782ad 100644
--- a/refs-common.c
+++ b/refs-common.c
@@ -784,3 +784,57 @@ int check_refname_format(const char *refname, int flags)
 		return -1; /* Refname has only one component. */
 	return 0;
 }
+
+/* backend functions */
+struct ref_transaction *transaction_begin(struct strbuf *err)
+{
+	return refs->transaction_begin(err);
+}
+
+int transaction_update_sha1(struct ref_transaction *transaction,
+			    const char *refname, const unsigned char *new_sha1,
+			    const unsigned char *old_sha1, int flags,
+			    int have_old, const char *msg, struct strbuf *err)
+{
+	return refs->transaction_update_sha1(transaction, refname, new_sha1,
+					     old_sha1, flags, have_old, msg,
+					     err);
+}
+
+int transaction_create_sha1(struct ref_transaction *transaction,
+			    const char *refname, const unsigned char *new_sha1,
+			    int flags, const char *msg, struct strbuf *err)
+{
+	return refs->transaction_create_sha1(transaction, refname, new_sha1,
+					     flags, msg, err);
+}
+int transaction_delete_sha1(struct ref_transaction *transaction,
+			    const char *refname, const unsigned char *old_sha1,
+			    int flags, int have_old, const char *msg,
+			    struct strbuf *err)
+{
+	return refs->transaction_delete_sha1(transaction, refname, old_sha1,
+					     flags, have_old, msg, err);
+}
+
+int transaction_update_reflog(struct ref_transaction *transaction,
+			      const char *refname,
+			      const unsigned char *new_sha1,
+			      const unsigned char *old_sha1,
+			      struct reflog_committer_info *ci,
+			      const char *msg, int flags,
+			      struct strbuf *err)
+{
+	return refs->transaction_update_reflog(transaction, refname, new_sha1,
+					       old_sha1, ci, msg, flags, err);
+}
+
+int transaction_commit(struct ref_transaction *transaction, struct strbuf *err)
+{
+	return refs->transaction_commit(transaction, err);
+}
+
+void transaction_free(struct ref_transaction *transaction)
+{
+	return refs->transaction_free(transaction);
+}
diff --git a/refs.c b/refs.c
index 9aa88ef..bfb42d8 100644
--- a/refs.c
+++ b/refs.c
@@ -2792,12 +2792,12 @@ struct ref_transaction {
 	enum ref_transaction_state state;
 };
 
-struct ref_transaction *transaction_begin(struct strbuf *err)
+static struct ref_transaction *files_transaction_begin(struct strbuf *err)
 {
 	return xcalloc(1, sizeof(struct ref_transaction));
 }
 
-void transaction_free(struct ref_transaction *transaction)
+static void files_transaction_free(struct ref_transaction *transaction)
 {
 	int i;
 
@@ -2827,13 +2827,13 @@ static struct ref_update *add_update(struct ref_transaction *transaction,
 	return update;
 }
 
-int transaction_update_reflog(struct ref_transaction *transaction,
-			      const char *refname,
-			      const unsigned char *new_sha1,
-			      const unsigned char *old_sha1,
-			      struct reflog_committer_info *ci,
-			      const char *msg, int flags,
-			      struct strbuf *err)
+static int files_transaction_update_reflog(struct ref_transaction *transaction,
+					   const char *refname,
+					   const unsigned char *new_sha1,
+					   const unsigned char *old_sha1,
+					   struct reflog_committer_info *ci,
+					   const char *msg, int flags,
+					   struct strbuf *err)
 {
 	struct ref_update *update;
 	int i;
@@ -2880,12 +2880,13 @@ int transaction_update_reflog(struct ref_transaction *transaction,
 	return 0;
 }
 
-int transaction_update_sha1(struct ref_transaction *transaction,
-			    const char *refname,
-			    const unsigned char *new_sha1,
-			    const unsigned char *old_sha1,
-			    int flags, int have_old, const char *msg,
-			    struct strbuf *err)
+static int files_transaction_update_sha1(struct ref_transaction *transaction,
+					 const char *refname,
+					 const unsigned char *new_sha1,
+					 const unsigned char *old_sha1,
+					 int flags, int have_old,
+					 const char *msg,
+					 struct strbuf *err)
 {
 	struct ref_update *update;
 
@@ -2912,11 +2913,11 @@ int transaction_update_sha1(struct ref_transaction *transaction,
 	return 0;
 }
 
-int transaction_create_sha1(struct ref_transaction *transaction,
-			    const char *refname,
-			    const unsigned char *new_sha1,
-			    int flags, const char *msg,
-			    struct strbuf *err)
+static int files_transaction_create_sha1(struct ref_transaction *transaction,
+					 const char *refname,
+					 const unsigned char *new_sha1,
+					 int flags, const char *msg,
+					 struct strbuf *err)
 {
 	if (transaction->state != REF_TRANSACTION_OPEN)
 		die("BUG: create called for transaction that is not open");
@@ -2928,11 +2929,12 @@ int transaction_create_sha1(struct ref_transaction *transaction,
 				       null_sha1, flags, 1, msg, err);
 }
 
-int transaction_delete_sha1(struct ref_transaction *transaction,
-			    const char *refname,
-			    const unsigned char *old_sha1,
-			    int flags, int have_old, const char *msg,
-			    struct strbuf *err)
+static int files_transaction_delete_sha1(struct ref_transaction *transaction,
+					 const char *refname,
+					 const unsigned char *old_sha1,
+					 int flags, int have_old,
+					 const char *msg,
+					 struct strbuf *err)
 {
 	if (transaction->state != REF_TRANSACTION_OPEN)
 		die("BUG: delete called for transaction that is not open");
@@ -2974,8 +2976,8 @@ static int ref_update_reject_duplicates(struct ref_update **updates, int n,
 	return 0;
 }
 
-int transaction_commit(struct ref_transaction *transaction,
-		       struct strbuf *err)
+static int files_transaction_commit(struct ref_transaction *transaction,
+				    struct strbuf *err)
 {
 	int ret = 0, delnum = 0, i, df_conflict = 0, need_repack = 0;
 	int num_updates = 0;
@@ -3299,3 +3301,15 @@ cleanup:
 		ret = -2;
 	return ret;
 }
+
+struct ref_be refs_files = {
+	.transaction_begin		= files_transaction_begin,
+	.transaction_update_sha1	= files_transaction_update_sha1,
+	.transaction_create_sha1	= files_transaction_create_sha1,
+	.transaction_delete_sha1	= files_transaction_delete_sha1,
+	.transaction_update_reflog	= files_transaction_update_reflog,
+	.transaction_commit		= files_transaction_commit,
+	.transaction_free		= files_transaction_free,
+};
+
+struct ref_be *refs = &refs_files;
diff --git a/refs.h b/refs.h
index 5577824..7b92241 100644
--- a/refs.h
+++ b/refs.h
@@ -350,4 +350,39 @@ int update_ref(const char *action, const char *refname,
 extern int parse_hide_refs_config(const char *var, const char *value, const char *);
 extern int ref_is_hidden(const char *);
 
+
+/* refs backends */
+typedef struct ref_transaction *(*transaction_begin_fn)(struct strbuf *err);
+typedef int (*transaction_update_sha1_fn)(struct ref_transaction *transaction,
+		const char *refname, const unsigned char *new_sha1,
+		const unsigned char *old_sha1, int flags, int have_old,
+		const char *msg, struct strbuf *err);
+typedef int (*transaction_create_sha1_fn)(struct ref_transaction *transaction,
+		const char *refname, const unsigned char *new_sha1,
+		int flags, const char *msg, struct strbuf *err);
+typedef int (*transaction_delete_sha1_fn)(struct ref_transaction *transaction,
+		const char *refname, const unsigned char *old_sha1,
+		int flags, int have_old, const char *msg, struct strbuf *err);
+typedef int (*transaction_update_reflog_fn)(
+		struct ref_transaction *transaction,
+		const char *refname, const unsigned char *new_sha1,
+		const unsigned char *old_sha1,
+		struct reflog_committer_info *ci,
+		const char *msg, int flags, struct strbuf *err);
+typedef int (*transaction_commit_fn)(struct ref_transaction *transaction,
+				       struct strbuf *err);
+typedef void (*transaction_free_fn)(struct ref_transaction *transaction);
+
+struct ref_be {
+	transaction_begin_fn transaction_begin;
+	transaction_update_sha1_fn transaction_update_sha1;
+	transaction_create_sha1_fn transaction_create_sha1;
+	transaction_delete_sha1_fn transaction_delete_sha1;
+	transaction_update_reflog_fn transaction_update_reflog;
+	transaction_commit_fn transaction_commit;
+	transaction_free_fn transaction_free;
+};
+
+extern struct ref_be *refs;
+
 #endif /* REFS_H */

-- 
2.0.1.553.geee1b3e
Previous: Ronnie SahlbergNext: David Turner
Message 20 of 26 in “backend-struct-db”
  1. 00/22 backend-struct-dbRonnie Sahlberg, Aug 8, 2014
  2. 01/22 refs.c: create a public function for is_refname_availableRonnie Sahlberg, Aug 8, 2014
  3. David TurnerAug 8, 2014
  4. Ronnie SahlbergAug 11, 2014
  5. 02/22 refs-common.c: create a file to host all common refs codeRonnie Sahlberg, Aug 8, 2014
  6. 03/22 refs-common.c: move update_ref to refs-common.cRonnie Sahlberg, Aug 8, 2014
  7. 04/22 refs-common.c: move delete_ref to the common codeRonnie Sahlberg, Aug 8, 2014
  8. 05/22 refs-common.c: move rename_ref to the common codeRonnie Sahlberg, Aug 8, 2014
  9. 06/22 refs-common.c: move read_ref_at to the refs common fileRonnie Sahlberg, Aug 8, 2014
  10. 07/22 refs-common.c: move the hidden refs functions to the common codeRonnie Sahlberg, Aug 8, 2014
  11. 08/22 refs-common.c: move dwim and friend functions to refs commonRonnie Sahlberg, Aug 8, 2014
  12. 09/22 refs-common.c: move warn_if_dangling_symref* to refs-commonRonnie Sahlberg, Aug 8, 2014
  13. 10/22 refs-common.c: move read_ref, read_ref_full and ref_exists to commonRonnie Sahlberg, Aug 8, 2014
  14. 11/22 refs-common.c: move resolve_refdup to commonRonnie Sahlberg, Aug 8, 2014
  15. 12/22 refs-common.c: move check_refname_component to the common codeRonnie Sahlberg, Aug 8, 2014
  16. 13/22 refs-common.c: move is_branch to the common codeRonnie Sahlberg, Aug 8, 2014
  17. 14/22 refs-common.c: move names_conflict to the common codeRonnie Sahlberg, Aug 8, 2014
  18. 15/22 refs-common.c: move prettify_refname to the common codeRonnie Sahlberg, Aug 8, 2014
  19. 16/22 refs-common.c: move ref iterators to the common codeRonnie Sahlberg, Aug 8, 2014
  20. 17/22 refs.c: add a backend method structure with transaction functionsRonnie Sahlberg, Aug 8, 2014
  21. David TurnerAug 8, 2014
  22. Ronnie SahlbergAug 11, 2014
  23. 18/22 refs.c: add reflog backend methodsRonnie Sahlberg, Aug 8, 2014
  24. 19/22 refs.c: add methods for misc ref operationsRonnie Sahlberg, Aug 8, 2014
  25. 20/22 refs.c: add methods for head_ref*Ronnie Sahlberg, Aug 8, 2014
  26. 21/22 refs.c: add methods for the ref iteratorsRonnie Sahlberg, Aug 8, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.