git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 06/20] replace.c: use the ref transaction functions for updates

From
Ronnie Sahlberg <sahlberg@google.com>
Date
Jul 15, 2014, 23:34 UTC
Message-ID
<1405467258-24102-7-git-send-email-sahlberg@google.com>
In-Reply-To
<1405467258-24102-1-git-send-email-sahlberg@google.com>
Update replace.c to use ref transactions for updates.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
---
 builtin/replace.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/builtin/replace.c b/builtin/replace.c
index 1bb491d..7528f3d 100644
--- a/builtin/replace.c
+++ b/builtin/replace.c
@@ -153,7 +153,8 @@ static int replace_object_sha1(const char *object_ref,
 	unsigned char prev[20];
 	enum object_type obj_type, repl_type;
 	char ref[PATH_MAX];
-	struct ref_lock *lock;
+	struct ref_transaction *transaction;
+	struct strbuf err = STRBUF_INIT;
 
 	obj_type = sha1_object_info(object, NULL);
 	repl_type = sha1_object_info(repl, NULL);
@@ -166,12 +167,14 @@ static int replace_object_sha1(const char *object_ref,
 
 	check_ref_valid(object, prev, ref, sizeof(ref), force);
 
-	lock = lock_any_ref_for_update(ref, prev, 0, NULL);
-	if (!lock)
-		die("%s: cannot lock the ref", ref);
-	if (write_ref_sha1(lock, repl, NULL) < 0)
-		die("%s: cannot update the ref", ref);
+	transaction = ref_transaction_begin(&err);
+	if (!transaction ||
+	    ref_transaction_update(transaction, ref, repl, prev,
+				   0, !is_null_sha1(prev), &err) ||
+	    ref_transaction_commit(transaction, NULL, &err))
+		die("%s", err.buf);
 
+	ref_transaction_free(transaction);
 	return 0;
 }
 
-- 
2.0.1.442.g7fe6834.dirty
Previous: Ronnie SahlbergNext: Ronnie Sahlberg
Message 7 of 24 in “ref transactions part 2”
  1. 00/20 ref transactions part 2Ronnie Sahlberg, Jul 15, 2014
  2. 01/20 refs.c: change ref_transaction_create to do error checking and return statusRonnie Sahlberg, Jul 15, 2014
  3. 02/20 refs.c: update ref_transaction_delete to check for error and return statusRonnie Sahlberg, Jul 15, 2014
  4. 03/20 refs.c: make ref_transaction_begin take an err argumentRonnie Sahlberg, Jul 15, 2014
  5. 04/20 refs.c: add transaction.status and track OPEN/CLOSED/ERRORRonnie Sahlberg, Jul 15, 2014
  6. 05/20 tag.c: use ref transactions when doing updatesRonnie Sahlberg, Jul 15, 2014
  7. 06/20 replace.c: use the ref transaction functions for updatesRonnie Sahlberg, Jul 15, 2014
  8. 07/20 commit.c: use ref transactions for updatesRonnie Sahlberg, Jul 15, 2014
  9. 08/20 sequencer.c: use ref transactions for all ref updatesRonnie Sahlberg, Jul 15, 2014
  10. 09/20 fast-import.c: change update_branch to use ref transactionsRonnie Sahlberg, Jul 15, 2014
  11. 10/20 branch.c: use ref transaction for all ref updatesRonnie Sahlberg, Jul 15, 2014
  12. 11/20 refs.c: change update_ref to use a transactionRonnie Sahlberg, Jul 15, 2014
  13. 12/20 receive-pack.c: use a reference transaction for updating the refsRonnie Sahlberg, Jul 15, 2014
  14. 13/20 fast-import.c: use a ref transaction when dumping tagsRonnie Sahlberg, Jul 15, 2014
  15. 14/20 walker.c: use ref transaction for ref updatesRonnie Sahlberg, Jul 15, 2014
  16. 15/20 refs.c: make lock_ref_sha1 staticRonnie Sahlberg, Jul 15, 2014
  17. 16/20 refs.c: remove the update_ref_lock functionRonnie Sahlberg, Jul 15, 2014
  18. 17/20 refs.c: remove the update_ref_write functionRonnie Sahlberg, Jul 15, 2014
  19. 18/20 refs.c: remove lock_ref_sha1Ronnie Sahlberg, Jul 15, 2014
  20. 19/20 refs.c: make prune_ref use a transaction to delete the refRonnie Sahlberg, Jul 15, 2014
  21. 20/20 refs.c: make delete_ref use a transactionRonnie Sahlberg, Jul 15, 2014
  22. Ronnie SahlbergJul 15, 2014
  23. Junio C HamanoJul 16, 2014
  24. Ronnie SahlbergJul 16, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.