git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 15/20] refs.c: make lock_ref_sha1 static

From
Ronnie Sahlberg <sahlberg@google.com>
Date
Jul 15, 2014, 23:34 UTC
Message-ID
<1405467258-24102-16-git-send-email-sahlberg@google.com>
In-Reply-To
<1405467258-24102-1-git-send-email-sahlberg@google.com>
No external callers reference lock_ref_sha1 any more so lets declare it static.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
---
 refs.c | 2 +-
 refs.h | 6 ------
 2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/refs.c b/refs.c
index ff4e799..10cea87 100644
--- a/refs.c
+++ b/refs.c
@@ -2170,7 +2170,7 @@ static struct ref_lock *lock_ref_sha1_basic(const char *refname,
 	return NULL;
 }
 
-struct ref_lock *lock_ref_sha1(const char *refname, const unsigned char *old_sha1)
+static struct ref_lock *lock_ref_sha1(const char *refname, const unsigned char *old_sha1)
 {
 	char refpath[PATH_MAX];
 	if (check_refname_format(refname, 0))
diff --git a/refs.h b/refs.h
index 3f37c65..65dd593 100644
--- a/refs.h
+++ b/refs.h
@@ -170,12 +170,6 @@ extern int ref_exists(const char *);
  */
 extern int peel_ref(const char *refname, unsigned char *sha1);
 
-/*
- * Locks a "refs/" ref returning the lock on success and NULL on failure.
- * On failure errno is set to something meaningful.
- */
-extern struct ref_lock *lock_ref_sha1(const char *refname, const unsigned char *old_sha1);
-
 /** Locks any ref (for 'HEAD' type refs). */
 #define REF_NODEREF	0x01
 /* errno is set to something meaningful on failure */
-- 
2.0.1.442.g7fe6834.dirty
Previous: Ronnie SahlbergNext: Ronnie Sahlberg
Message 16 of 24 in “ref transactions part 2”
  1. 00/20 ref transactions part 2Ronnie Sahlberg, Jul 15, 2014
  2. 01/20 refs.c: change ref_transaction_create to do error checking and return statusRonnie Sahlberg, Jul 15, 2014
  3. 02/20 refs.c: update ref_transaction_delete to check for error and return statusRonnie Sahlberg, Jul 15, 2014
  4. 03/20 refs.c: make ref_transaction_begin take an err argumentRonnie Sahlberg, Jul 15, 2014
  5. 04/20 refs.c: add transaction.status and track OPEN/CLOSED/ERRORRonnie Sahlberg, Jul 15, 2014
  6. 05/20 tag.c: use ref transactions when doing updatesRonnie Sahlberg, Jul 15, 2014
  7. 06/20 replace.c: use the ref transaction functions for updatesRonnie Sahlberg, Jul 15, 2014
  8. 07/20 commit.c: use ref transactions for updatesRonnie Sahlberg, Jul 15, 2014
  9. 08/20 sequencer.c: use ref transactions for all ref updatesRonnie Sahlberg, Jul 15, 2014
  10. 09/20 fast-import.c: change update_branch to use ref transactionsRonnie Sahlberg, Jul 15, 2014
  11. 10/20 branch.c: use ref transaction for all ref updatesRonnie Sahlberg, Jul 15, 2014
  12. 11/20 refs.c: change update_ref to use a transactionRonnie Sahlberg, Jul 15, 2014
  13. 12/20 receive-pack.c: use a reference transaction for updating the refsRonnie Sahlberg, Jul 15, 2014
  14. 13/20 fast-import.c: use a ref transaction when dumping tagsRonnie Sahlberg, Jul 15, 2014
  15. 14/20 walker.c: use ref transaction for ref updatesRonnie Sahlberg, Jul 15, 2014
  16. 15/20 refs.c: make lock_ref_sha1 staticRonnie Sahlberg, Jul 15, 2014
  17. 16/20 refs.c: remove the update_ref_lock functionRonnie Sahlberg, Jul 15, 2014
  18. 17/20 refs.c: remove the update_ref_write functionRonnie Sahlberg, Jul 15, 2014
  19. 18/20 refs.c: remove lock_ref_sha1Ronnie Sahlberg, Jul 15, 2014
  20. 19/20 refs.c: make prune_ref use a transaction to delete the refRonnie Sahlberg, Jul 15, 2014
  21. 20/20 refs.c: make delete_ref use a transactionRonnie Sahlberg, Jul 15, 2014
  22. Ronnie SahlbergJul 15, 2014
  23. Junio C HamanoJul 16, 2014
  24. Ronnie SahlbergJul 16, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.