[PATCH v2 1/9] t4203: demonstrate loss of single-character name in mailmap entry
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Jul 15, 2013, 06:54 UTC
- Message-ID
- <1373871253-96480-2-git-send-email-sunshine@sunshineco.com>
- In-Reply-To
- <1373871253-96480-1-git-send-email-sunshine@sunshineco.com>
A bug in mailmap.c:parse_name_and_email() causes it to overlook the single-character name in "A <user@host>" and parse it only as "<user@host>". Demonstrate this problem.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> --- t/t4203-mailmap.sh | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/t/t4203-mailmap.sh b/t/t4203-mailmap.sh index 842b754..27f8f86 100755 --- a/t/t4203-mailmap.sh +++ b/t/t4203-mailmap.sh @@ -247,6 +247,15 @@ test_expect_success 'cleanup after mailmap.blob tests' ' rm -f .mailmap ' +test_expect_failure 'single-character name' ' + echo " 1 A <author@example.com>" >expect && + echo " 1 nick1 <bugs@company.xx>" >>expect && + echo "A <author@example.com>" >.mailmap && + test_when_finished "rm .mailmap" && + git shortlog -es HEAD >actual && + test_cmp expect actual +' + # Extended mailmap configurations should give us the following output for shortlog cat >expect <<\EOF A U Thor <author@example.com> (1):
-- 1.8.3.2.804.g0da7a53