From: Eric Sunshine Date: Mon, 15 Jul 2013 06:54:05 GMT Subject: [PATCH v2 1/9] t4203: demonstrate loss of single-character name in mailmap entry Message-ID: <1373871253-96480-2-git-send-email-sunshine@sunshineco.com> In-Reply-To: <1373871253-96480-1-git-send-email-sunshine@sunshineco.com> A bug in mailmap.c:parse_name_and_email() causes it to overlook the single-character name in "A " and parse it only as "". Demonstrate this problem. Signed-off-by: Eric Sunshine --- t/t4203-mailmap.sh | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/t/t4203-mailmap.sh b/t/t4203-mailmap.sh index 842b754..27f8f86 100755 --- a/t/t4203-mailmap.sh +++ b/t/t4203-mailmap.sh @@ -247,6 +247,15 @@ test_expect_success 'cleanup after mailmap.blob tests' ' rm -f .mailmap ' +test_expect_failure 'single-character name' ' + echo " 1 A " >expect && + echo " 1 nick1 " >>expect && + echo "A " >.mailmap && + test_when_finished "rm .mailmap" && + git shortlog -es HEAD >actual && + test_cmp expect actual +' + # Extended mailmap configurations should give us the following output for shortlog cat >expect <<\EOF A U Thor (1): -- 1.8.3.2.804.g0da7a53