git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 5/9] mailmap: debug: fix out-of-order fprintf() arguments

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 15, 2013, 15:18 UTC
Message-ID
<7vwqordf7b.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1373871253-96480-6-git-send-email-sunshine@sunshineco.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
> Resolve segmentation fault due to arguments passed in wrong order.
>
> Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>

Thanks. Shows that the debugging support hasn't been in use for quite a long time X-<.

Show 17 quoted lines
> ---
>  mailmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mailmap.c b/mailmap.c
> index a7e92db..0516354 100644
> --- a/mailmap.c
> +++ b/mailmap.c
> @@ -309,7 +309,7 @@ int map_user(struct string_list *map,
>  	struct mailmap_entry *me;
>  
>  	debug_mm("map_user: map '%.*s' <%.*s>\n",
> -		 *name, *namelen, *emaillen, *email);
> +		 *namelen, *name, *emaillen, *email);
>  
>  	item = lookup_prefix(map, *email, *emaillen);
>  	if (item != NULL) {
Previous: Eric SunshineNext: Eric Sunshine
Message 7 of 12 in “mailmap fixes”
  1. 0/9 mailmap fixesEric Sunshine, Jul 15, 2013
  2. 1/9 t4203: demonstrate loss of single-character name in mailmap entryEric Sunshine, Jul 15, 2013
  3. 2/9 mailmap: do not lose single-letter namesEric Sunshine, Jul 15, 2013
  4. 3/9 t4203: demonstrate loss of uppercase characters in canonical emailEric Sunshine, Jul 15, 2013
  5. 4/9 mailmap: do not downcase mailmap entriesEric Sunshine, Jul 15, 2013
  6. 5/9 mailmap: debug: fix out-of-order fprintf() argumentsEric Sunshine, Jul 15, 2013
  7. Junio C HamanoJul 15, 2013
  8. 6/9 mailmap: debug: fix malformed fprintf() format directiveEric Sunshine, Jul 15, 2013
  9. 7/9 mailmap: debug: eliminate -Wformat field precision type warningEric Sunshine, Jul 15, 2013
  10. 8/9 mailmap: debug: avoid passing NULL to fprintf() '%s' directiveEric Sunshine, Jul 15, 2013
  11. 9/9 mailmap: style fixesEric Sunshine, Jul 15, 2013
  12. Junio C HamanoJul 15, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.