[PATCH 2/4] resolve_ref_unsafe(): handle the case of an SHA-1 within loop
- From
Michael Haggerty <mhagger@alum.mit.edu>
- Date
- Jun 11, 2013, 14:26 UTC
- Message-ID
- <1370960780-1055-3-git-send-email-mhagger@alum.mit.edu>
- In-Reply-To
- <1370960780-1055-1-git-send-email-mhagger@alum.mit.edu>
There is only one "break" statement within the loop, which jumps to the code after the loop that handles the case of a file that holds a SHA-1. So move that code from below the loop into the if statement where the break was previously located. This makes the logic flow more local and also opens the way for nesting the checking code in an inner loop.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> --- refs.c | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/refs.c b/refs.c index 1acce17..2722f75 100644 --- a/refs.c +++ b/refs.c @@ -1295,8 +1295,19 @@ const char *resolve_ref_unsafe(const char *refname, unsigned char *sha1, int rea /* * Is it a symbolic ref? */ - if (prefixcmp(buffer, "ref:")) - break; + if (prefixcmp(buffer, "ref:")) { + /* + * Please note that FETCH_HEAD has a second + * line containing other data. + */ + if (get_sha1_hex(buffer, sha1) || + (buffer[40] != '\0' && !isspace(buffer[40]))) { + if (flag) + *flag |= REF_ISBROKEN; + return NULL; + } + return refname; + } if (flag) *flag |= REF_ISSYMREF; buf = buffer + 4; @@ -1309,13 +1320,6 @@ const char *resolve_ref_unsafe(const char *refname, unsigned char *sha1, int rea } refname = strcpy(refname_buffer, buf); } - /* Please note that FETCH_HEAD has a second line containing other data. */ - if (get_sha1_hex(buffer, sha1) || (buffer[40] != '\0' && !isspace(buffer[40]))) { - if (flag) - *flag |= REF_ISBROKEN; - return NULL; - } - return refname; } char *resolve_refdup(const char *ref, unsigned char *sha1, int reading, int *flag)
-- 1.8.3