git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 5/6] transport-helper: trivial code shuffle

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Apr 18, 2013, 00:05 UTC
Message-ID
<1366243524-18202-6-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1366243524-18202-1-git-send-email-felipe.contreras@gmail.com>

Just shuffle the die() part to make it more explicit, and cleanup the code-style.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 transport-helper.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/transport-helper.c b/transport-helper.c
index 573eaf7..9d31f2d 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -800,6 +800,9 @@ static int push_refs_with_export(struct transport *transport,
 		char *private;
 		unsigned char sha1[20];
 
+		if (ref->deletion)
+			die("remote-helpers do not support ref deletion");
+
 		private = apply_refspecs(data->refspecs, data->refspec_nr, ref->name);
 		if (private && !get_sha1(private, sha1)) {
 			strbuf_addf(&buf, "^%s", private);
@@ -807,13 +810,8 @@ static int push_refs_with_export(struct transport *transport,
 		}
 		free(private);
 
-		if (ref->deletion) {
-			die("remote-helpers do not support ref deletion");
-		}
-
 		if (ref->peer_ref)
 			string_list_append(&revlist_args, ref->peer_ref->name);
-
 	}
 
 	if (get_exporter(transport, &exporter, &revlist_args))
-- 
1.8.2.1.679.g509521a
Previous: Felipe ContrerasNext: Felipe Contreras
Message 12 of 14 in “transport-helper: some clarifications and a fix”
  1. 0/6 transport-helper: some clarifications and a fixFelipe Contreras, Apr 18, 2013
  2. 1/6 transport-helper: clarify *:* refspecFelipe Contreras, Apr 18, 2013
  3. Thomas RastApr 18, 2013
  4. Felipe ContrerasApr 18, 2013
  5. Thomas RastApr 18, 2013
  6. Felipe ContrerasApr 18, 2013
  7. 2/6 transport-helper: update refspec documentationFelipe Contreras, Apr 18, 2013
  8. 3/6 transport-helper: clarify pushing without refspecsFelipe Contreras, Apr 18, 2013
  9. Sverre RabbelierApr 18, 2013
  10. Stefano LattariniApr 18, 2013
  11. 4/6 transport-helper: warn when refspec is not usedFelipe Contreras, Apr 18, 2013
  12. 5/6 transport-helper: trivial code shuffleFelipe Contreras, Apr 18, 2013
  13. 6/6 transport-helper: update remote helper namespaceFelipe Contreras, Apr 18, 2013
  14. Felipe ContrerasApr 18, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.