From: Felipe Contreras Date: Thu, 18 Apr 2013 00:05:23 GMT Subject: [PATCH 5/6] transport-helper: trivial code shuffle Message-ID: <1366243524-18202-6-git-send-email-felipe.contreras@gmail.com> In-Reply-To: <1366243524-18202-1-git-send-email-felipe.contreras@gmail.com> Just shuffle the die() part to make it more explicit, and cleanup the code-style. Signed-off-by: Felipe Contreras --- transport-helper.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/transport-helper.c b/transport-helper.c index 573eaf7..9d31f2d 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -800,6 +800,9 @@ static int push_refs_with_export(struct transport *transport, char *private; unsigned char sha1[20]; + if (ref->deletion) + die("remote-helpers do not support ref deletion"); + private = apply_refspecs(data->refspecs, data->refspec_nr, ref->name); if (private && !get_sha1(private, sha1)) { strbuf_addf(&buf, "^%s", private); @@ -807,13 +810,8 @@ static int push_refs_with_export(struct transport *transport, } free(private); - if (ref->deletion) { - die("remote-helpers do not support ref deletion"); - } - if (ref->peer_ref) string_list_append(&revlist_args, ref->peer_ref->name); - } if (get_exporter(transport, &exporter, &revlist_args)) -- 1.8.2.1.679.g509521a