Re: [PATCH 1/6] transport-helper: clarify *:* refspec
- From
Thomas Rast <trast@inf.ethz.ch>
- Date
- Apr 18, 2013, 07:28 UTC
- Message-ID
- <87li8gxpq2.fsf@linux-k42r.v.cablecom.net>
- In-Reply-To
- <1366243524-18202-2-git-send-email-felipe.contreras@gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
> The *:* refspec doesn't work, and never has, clarify the code and > documentation to reflect that. This in effect reverts commit 9e7673e > (gitremote-helpers(1): clarify refspec behaviour).
[...]
Show 14 quoted lines
> -test_expect_success 'pulling with straight refspec' ' > - (cd local2 && > - GIT_REMOTE_TESTGIT_REFSPEC="*:*" git pull) && > - compare_refs local2 HEAD server HEAD > -' > - > -test_expect_failure 'pushing with straight refspec' ' > - test_when_finished "(cd local2 && git reset --hard origin)" && > - (cd local2 && > - echo content >>file && > - git commit -a -m eleven && > - GIT_REMOTE_TESTGIT_REFSPEC="*:*" git push) && > - compare_refs local2 HEAD server HEAD > -'
So what's wrong with the tests? Do they fail to test what they claim (how?), test something that wasn't reasonable to begin with, or something entirely different?
--
Thomas Rast
trast@{inf,student}.ethz.ch