[PATCH v7 4/7] tests: change info messages from yellow/brown to cyan
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 21, 2012, 03:12 UTC
- Message-ID
- <1356059558-23479-5-git-send-email-gitster@pobox.com>
- In-Reply-To
- <1356059558-23479-1-git-send-email-gitster@pobox.com>
From: Adam Spiers <git@adamspiers.org>
Now that we've adopted a "traffic lights" coloring scheme, yellow is used for warning messages, so we need to re-color info messages to something less alarmist. Blue is a universal color for informational messages; however we are using that for skipped tests in order to align with the color schemes of other test suites. Therefore we use cyan which is also blue-ish, but visually distinct from blue.
This was suggested on the list a while ago and no-one raised any objections:
http://thread.gmane.org/gmane.comp.version-control.git/205675/focus=205966
An earlier iteration of this patch used bold cyan, but the point of this change is to make them less alarming; let's drop the boldness.
Also paint the message to report skipping the whole thing via GIT_SKIP_TESTS mechanism in the same color as the "info" color that is used on the final summary line for the entire script.
Signed-off-by: Adam Spiers <git@adamspiers.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> --- t/test-lib.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh index f32df80..8b75c9a 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -186,9 +186,9 @@ then warn) tput setaf 3;; # brown/yellow pass) - tput setaf 2;; # green + tput setaf 2;; # green info) - tput setaf 3;; # brown + tput setaf 6;; # cyan *) test -n "$quiet" && return;; esac @@ -584,7 +584,7 @@ for skp in $GIT_SKIP_TESTS do case "$this_test" in $skp) - say_color skip >&3 "skipping test $this_test altogether" + say_color info >&3 "skipping test $this_test altogether" skip_all="skip all tests in $this_test" test_done esac
-- 1.8.1.rc2.225.g8d36ab4