[PATCH v7 2/7] tests: paint known breakages in yellow
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 21, 2012, 03:12 UTC
- Message-ID
- <1356059558-23479-3-git-send-email-gitster@pobox.com>
- In-Reply-To
- <1356059558-23479-1-git-send-email-gitster@pobox.com>
From: Adam Spiers <git@adamspiers.org>
Yellow seems a more appropriate color than bold green when considering the universal traffic lights coloring scheme, where green conveys the impression that everything's OK, and amber that something's not quite right.
Likewise, change the color of the summarized total number of known breakages from bold red to the same yellow to be less alarmist and more consistent with the above.
An earlier version of this patch used bold yellow but because these are all long-known failures, reminding them to developers in bold over and over does not help encouraging them to take a look at them very much. This iteration paints them in plain yellow instead to make them less distracting.
Signed-off-by: Adam Spiers <git@adamspiers.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> --- t/test-lib.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh index 03b86b8..72aafd0 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -183,6 +183,8 @@ then tput bold; tput setaf 1;; # bold red skip) tput bold; tput setaf 2;; # bold green + warn) + tput setaf 3;; # brown/yellow pass) tput setaf 2;; # green info) @@ -281,7 +283,7 @@ test_known_broken_ok_ () { test_known_broken_failure_ () { test_broken=$(($test_broken+1)) - say_color skip "not ok $test_count - $@ # TODO known breakage" + say_color warn "not ok $test_count - $@ # TODO known breakage" } test_debug () { @@ -375,7 +377,7 @@ test_done () { fi if test "$test_broken" != 0 then - say_color error "# still have $test_broken known breakage(s)" + say_color warn "# still have $test_broken known breakage(s)" msg="remaining $(($test_count-$test_broken)) test(s)" else msg="$test_count test(s)"
-- 1.8.1.rc2.225.g8d36ab4