git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v7 1/7] tests: test number comes first in 'not ok $count - $message'

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 21, 2012, 03:12 UTC
Message-ID
<1356059558-23479-2-git-send-email-gitster@pobox.com>
In-Reply-To
<1356059558-23479-1-git-send-email-gitster@pobox.com>
From: Adam Spiers <git@adamspiers.org>

The old output to say "not ok - 1 messsage" was working by accident only because the test numbers are optional in TAP.

Signed-off-by: Adam Spiers <git@adamspiers.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t0000-basic.sh | 4 ++--
 t/test-lib.sh    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
index ae6a3f0..c6b42de 100755
--- a/t/t0000-basic.sh
+++ b/t/t0000-basic.sh
@@ -167,13 +167,13 @@ test_expect_success 'tests clean up even on failures' "
 	! test -s err &&
 	! test -f \"trash directory.failing-cleanup/clean-after-failure\" &&
 	sed -e 's/Z$//' -e 's/^> //' >expect <<-\\EOF &&
-	> not ok - 1 tests clean up even after a failure
+	> not ok 1 - tests clean up even after a failure
 	> #	Z
 	> #	touch clean-after-failure &&
 	> #	test_when_finished rm clean-after-failure &&
 	> #	(exit 1)
 	> #	Z
-	> not ok - 2 failure to clean up causes the test to fail
+	> not ok 2 - failure to clean up causes the test to fail
 	> #	Z
 	> #	test_when_finished \"(exit 2)\"
 	> #	Z
diff --git a/t/test-lib.sh b/t/test-lib.sh
index f8e3733..03b86b8 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -268,7 +268,7 @@ test_ok_ () {
 
 test_failure_ () {
 	test_failure=$(($test_failure + 1))
-	say_color error "not ok - $test_count $1"
+	say_color error "not ok $test_count - $1"
 	shift
 	echo "$@" | sed -e 's/^/#	/'
 	test "$immediate" = "" || { GIT_EXIT_OK=t; exit 1; }
-- 
1.8.1.rc2.225.g8d36ab4
Previous: Junio C HamanoNext: Junio C Hamano
Message 2 of 13 in “coloring test output after traffic signal”
  1. 0/7 coloring test output after traffic signalJunio C Hamano, Dec 21, 2012
  2. 1/7 tests: test number comes first in 'not ok $count - $message'Junio C Hamano, Dec 21, 2012
  3. 2/7 tests: paint known breakages in yellowJunio C Hamano, Dec 21, 2012
  4. Stefano LattariniDec 21, 2012
  5. Junio C HamanoDec 21, 2012
  6. Stefano LattariniDec 21, 2012
  7. 3/7 tests: paint skipped tests in blueJunio C Hamano, Dec 21, 2012
  8. 4/7 tests: change info messages from yellow/brown to cyanJunio C Hamano, Dec 21, 2012
  9. 5/7 tests: refactor mechanics of testing in a sub test-libJunio C Hamano, Dec 21, 2012
  10. 6/7 tests: test the test framework more thoroughlyJunio C Hamano, Dec 21, 2012
  11. 7/7 tests: paint unexpectedly fixed known breakages in bold redJunio C Hamano, Dec 21, 2012
  12. Jeff KingDec 21, 2012
  13. Adam SpiersDec 21, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.