git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC/PATCH v2 4/8] tmp: completion: add SZEDER's tests

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Nov 18, 2012, 10:56 UTC
Message-ID
<1353236213-13471-5-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1353236213-13471-1-git-send-email-felipe.contreras@gmail.com>
Separate patch series, but the results are relevant.
+ modifications from me.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 t/t9902-completion.sh | 61 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 61 insertions(+)
diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
index 79a2453..35fc31b 100755
--- a/t/t9902-completion.sh
+++ b/t/t9902-completion.sh
@@ -73,6 +73,24 @@ test_completion_long ()
 
 newline=$'\n'
 
+# Test __gitcomp_nl
+# Arguments are:
+# 1: current word (cur)
+# -: the rest are passed to __gitcomp_nl
+test_gitcomp_nl ()
+{
+	local -a COMPREPLY &&
+	sed -e 's/Z$//' > expected &&
+	cur="$1" &&
+	shift &&
+	__gitcomp_nl "$@" &&
+	print_comp &&
+	cp expected out /tmp
+	test_cmp expected out
+}
+
+invalid_variable_name="${foo.bar}"
+
 test_expect_success '__gitcomp - trailing space - options' '
 	sed -e "s/Z$//" >expected <<-\EOF &&
 	--reuse-message=Z
@@ -156,6 +174,49 @@ test_expect_success '__gitcomp - suffix' '
 	test_cmp expected out
 '
 
+test_expect_failure '__gitcomp - doesnt fail because of invalid variable name' '
+	__gitcomp "$invalid_variable_name"
+'
+
+read -r -d "" refs <<-\EOF
+maint
+master
+next
+pu
+EOF
+
+test_expect_success '__gitcomp_nl - trailing space' '
+	test_gitcomp_nl "m" "$refs" <<-EOF
+	maint Z
+	master Z
+	EOF
+'
+
+test_expect_success '__gitcomp_nl - prefix' '
+	test_gitcomp_nl "--fixup=m" "$refs" "--fixup=" "m" <<-EOF
+	--fixup=maint Z
+	--fixup=master Z
+	EOF
+'
+
+test_expect_success '__gitcomp_nl - suffix' '
+	test_gitcomp_nl "branch.ma" "$refs" "branch." "ma" "." <<-\EOF
+	branch.maint.Z
+	branch.master.Z
+	EOF
+'
+
+test_expect_success '__gitcomp_nl - no suffix' '
+	test_gitcomp_nl "ma" "$refs" "" "ma" "" <<-\EOF
+	maintZ
+	masterZ
+	EOF
+'
+
+test_expect_failure '__gitcomp_nl - doesnt fail because of invalid variable name' '
+	__gitcomp_nl "$invalid_variable_name"
+'
+
 test_expect_success 'basic' '
 	run_completion "git " &&
 	# built-in
-- 
1.8.0
Previous: Felipe ContrerasNext: Felipe Contreras
Message 5 of 9 in “completion: compgen/compadd cleanups”
  1. 0/8 completion: compgen/compadd cleanupsFelipe Contreras, Nov 18, 2012
  2. 1/8 completion: trivial test improvementFelipe Contreras, Nov 18, 2012
  3. 2/8 completion: get rid of empty COMPREPLY assignmentsFelipe Contreras, Nov 18, 2012
  4. 3/8 completion: add new __gitcompadd helperFelipe Contreras, Nov 18, 2012
  5. 4/8 tmp: completion: add SZEDER's testsFelipe Contreras, Nov 18, 2012
  6. 5/8 completion: get rid of compgenFelipe Contreras, Nov 18, 2012
  7. 6/8 tmp: completion: mark SZEDER's tests as fixedFelipe Contreras, Nov 18, 2012
  8. 7/8 completion: get rid of __gitcomp_1Felipe Contreras, Nov 18, 2012
  9. 8/8 completion: small optimizationFelipe Contreras, Nov 18, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.